On 2019/3/6 0:48, Gerd Rausch wrote:
Hi Santosh,
On 05/03/2019 08.41, Santosh Shilimkar wrote:
On 3/5/2019 8:33 AM, Gerd Rausch wrote:
If there's a mechanism that ensures compatibility with older (pre-4.1) versions
of RDS I am not seeing it.
Thats handled as part of the connection reject handler as part of negotiation.
Evidentally, that mechanism isn't working properly.
The inconsistency in comment vs. code doesn't help in that regard.
Yeah the comment should have been updated.
And tests illustrated this incompatibility:
2 peers with this patchset can talk to eachother.
Peers with a mix of post-this-patchset and pre-this-patchset can no longer talk
to eachother.
They can talk to each other as per Yanjun tests.
I am happy to hear it worked for him, but is it possible that his tests may
have been incomplete?
In a unicast e-mail conversation with Yanjun, he acknowledged:
"Now I found another hosts and I can reproduce Gerd's bug on the hosts. Now I am
working on the hosts to find the root cause."
Sorry. It is late to reply. I explained it in details. Just now I made
tests with 4.20.0(without qos) and 5.0.0-rc8 (with qos).
When run rds-stress without rdma, it can work well.
With rdma, there is some problem with rds-stress. This is a known
problem. From Gerd, he has some commits to fix it.
Zhu Yanjun
So we have non-working code in David's repository, which I consider not to be a
good thing.
He is working on setting it up net-next to see if something got missed out.
Stay tune. Will update about the results.
Can we back this patchset out again until we have working & compatible code?
Thanks,
Gerd
