Re: [RFC PATCH 1/2] gianfar: convert to phylink

2019-09-04 Thread Arseny Solokha
> Hi Arseny. > > On Tue, 30 Jul 2019 at 17:40, Arseny Solokha wrote: >> >> > Hi Arseny, >> > >> > Nice project! >> >> Vladimir, Russell, thanks for your review. I'm on vacation now, so won't >> fully >> address your comments in a few weeks: while I can build the code, I won't >> have >> access t

Re: [RFC PATCH 1/2] gianfar: convert to phylink

2019-09-04 Thread Arseny Solokha
Hi, >> @@ -1964,7 +1966,7 @@ void stop_gfar(struct net_device *dev) >> /* disable ints and gracefully shut down Rx/Tx DMA */ >> gfar_halt(priv); >> >> - phy_stop(dev->phydev); >> + phylink_stop(priv->phylink); >> >> free_skb_resources(priv); >> } >> @@ -2219,1

Re: [RFC PATCH 1/2] gianfar: convert to phylink

2019-08-28 Thread Vladimir Oltean
Hi Arseny, On Sat, 24 Aug 2019 at 18:21, Vladimir Oltean wrote: > > Hi Arseny. > > On Tue, 30 Jul 2019 at 17:40, Arseny Solokha wrote: > > > > > Hi Arseny, > > > > > > Nice project! > > > > Vladimir, Russell, thanks for your review. I'm on vacation now, so won't > > fully > > address your comme

Re: [RFC PATCH 1/2] gianfar: convert to phylink

2019-08-24 Thread Vladimir Oltean
Hi Arseny. On Tue, 30 Jul 2019 at 17:40, Arseny Solokha wrote: > > > Hi Arseny, > > > > Nice project! > > Vladimir, Russell, thanks for your review. I'm on vacation now, so won't fully > address your comments in a few weeks: while I can build the code, I won't have > access to hardware to test. >

Re: [RFC PATCH 1/2] gianfar: convert to phylink

2019-08-24 Thread Vladimir Oltean
Hi Russell, On Tue, 30 Jul 2019 at 13:23, Russell King - ARM Linux admin wrote: > > On Tue, Jul 30, 2019 at 02:39:58AM +0300, Vladimir Oltean wrote: > > To be honest I don't have a complete answer to that question. The > > literature recommends writing 0x01a0 to the MII_ADVERTISE (0x4) > > regist

Re: [RFC PATCH 1/2] gianfar: convert to phylink

2019-07-30 Thread Arseny Solokha
> Hi Arseny, > > Nice project! Vladimir, Russell, thanks for your review. I'm on vacation now, so won't fully address your comments in a few weeks: while I can build the code, I won't have access to hardware to test. So it seems this patch will turn into a series where we'll have some cleanup pat

Re: [RFC PATCH 1/2] gianfar: convert to phylink

2019-07-30 Thread Russell King - ARM Linux admin
On Tue, Jul 30, 2019 at 02:39:58AM +0300, Vladimir Oltean wrote: > To be honest I don't have a complete answer to that question. The > literature recommends writing 0x01a0 to the MII_ADVERTISE (0x4) > register of the MAC PCS for 1000Base-X, and 0x4001 for SGMII. That looks entirely sane for both m

Re: [RFC PATCH 1/2] gianfar: convert to phylink

2019-07-29 Thread Vladimir Oltean
Hi Arseny, Nice project! On Wed, 24 Jul 2019 at 03:38, Arseny Solokha wrote: > > Convert gianfar to use the phylink API for better SFP modules support. > > The driver still uses phylib for serdes configuration over the TBI > interface, as there seems to be no functionally equivalent API present

Re: [RFC PATCH 1/2] gianfar: convert to phylink

2019-07-24 Thread Russell King - ARM Linux admin
On Tue, Jul 23, 2019 at 10:17:01PM +0700, Arseny Solokha wrote: > -static noinline void gfar_update_link_state(struct gfar_private *priv) > +static void gfar_mac_config(struct phylink_config *config, unsigned int mode, > + const struct phylink_link_state *state) > { > +

Re: [RFC PATCH 1/2] gianfar: convert to phylink

2019-07-24 Thread Arseny Solokha
>>-Original Message- >>From: Arseny Solokha >>Sent: Tuesday, July 23, 2019 6:17 PM >>To: Claudiu Manoil ; Ioana Ciornei >>; Russell King ; Andrew Lunn >> >>Cc: netdev@vger.kernel.org; Arseny Solokha >>Subject: [RFC PATCH 1/2] gianfar: convert to phylink >> >>Convert gianfar to use the phy

RE: [RFC PATCH 1/2] gianfar: convert to phylink

2019-07-23 Thread Claudiu Manoil
>-Original Message- >From: Arseny Solokha >Sent: Tuesday, July 23, 2019 6:17 PM >To: Claudiu Manoil ; Ioana Ciornei >; Russell King ; Andrew Lunn > >Cc: netdev@vger.kernel.org; Arseny Solokha >Subject: [RFC PATCH 1/2] gianfar: convert to phylink > >Convert gianfar to use the phylink API f