>-----Original Message----- >From: Arseny Solokha <asolo...@kb.kras.ru> >Sent: Tuesday, July 23, 2019 6:17 PM >To: Claudiu Manoil <claudiu.man...@nxp.com>; Ioana Ciornei ><ioana.cior...@nxp.com>; Russell King <li...@armlinux.org.uk>; Andrew Lunn ><and...@lunn.ch> >Cc: netdev@vger.kernel.org; Arseny Solokha <asolo...@kb.kras.ru> >Subject: [RFC PATCH 1/2] gianfar: convert to phylink > >Convert gianfar to use the phylink API for better SFP modules support. > >The driver still uses phylib for serdes configuration over the TBI >interface, as there seems to be no functionally equivalent API present >in phylink (yet). phylib usage is basically confined in two functions. >
Thanks for your patch. Phylink in gianfar... that would be something! At first glance a lot of code has changed with this patch or got relocated. To make it easier to swallow, I think a few cleanup patches could be separated before migrating to phylink. Like for instance getting rid of the old* link state variables, which I think are an artifact from early phylib usage. Nonetheless good to see this implemented, I'll have a closer look asap. Thanks Claudiu
