Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

2020-05-14 Thread David Miller
From: David Miller Date: Thu, 14 May 2020 13:09:52 -0700 (PDT) > Actually, I had to revert, please fix these warnings (with gcc-10.1.1 on > Fedora)_: > > drivers/net/ethernet/qlogic/qed/qed_dev.c: In function > ‘qed_llh_add_mac_filter’: > ./include/linux/printk.h:303:2: warning: ‘abs_ppfid’ ma

Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

2020-05-14 Thread David Miller
From: David Miller Date: Thu, 14 May 2020 13:01:59 -0700 (PDT) > From: Igor Russkikh > Date: Thu, 14 May 2020 12:57:16 +0300 > >> FastLinQ devices as a complex systems may observe various hardware >> level error conditions, both severe and recoverable. >> >> Driver is able to detect and report

Re: [EXT] Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

2020-05-14 Thread Igor Russkikh
On 14/05/2020 11:02 pm, Jakub Kicinski wrote: > That's fine, I'm just saying - I hope the devlink part doesn't take too > long to implement :) > > I'm only applying this series because I trust that you will actually do > the > devlink work, and you will have it done and submitted in a reasona

Re: [EXT] Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

2020-05-14 Thread Jakub Kicinski
On Thu, 14 May 2020 22:40:12 +0300 Igor Russkikh wrote: > > I'm not 100% happy that the debug data gets reported to the management > > FW before the devlink health code is in place. For the Linux community, > > I think, having standard Linux interfaces implemented first is the > > priority. > >

Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

2020-05-14 Thread David Miller
From: Igor Russkikh Date: Thu, 14 May 2020 12:57:16 +0300 > FastLinQ devices as a complex systems may observe various hardware > level error conditions, both severe and recoverable. > > Driver is able to detect and report this, but so far it only did > trace/dmesg based reporting. > > Here we i

Re: [EXT] Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

2020-05-14 Thread Igor Russkikh
> I'm not 100% happy that the debug data gets reported to the management > FW before the devlink health code is in place. For the Linux community, > I think, having standard Linux interfaces implemented first is the > priority. Hi Jakub, Thanks for the comment. I feel these two are a bit separa

Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

2020-05-14 Thread Jakub Kicinski
On Thu, 14 May 2020 12:57:16 +0300 Igor Russkikh wrote: > FastLinQ devices as a complex systems may observe various hardware > level error conditions, both severe and recoverable. > > Driver is able to detect and report this, but so far it only did > trace/dmesg based reporting. > > Here we imple