RE: [net-next v3 06/15] iecm: Implement mailbox functionality

2020-06-29 Thread Brady, Alan
oshua A ; Chittim, Madhu > ; Linga, Pavan Kumar > ; Skidmore, Donald C > ; Brandeburg, Jesse > ; Samudrala, Sridhar > > Subject: Re: [net-next v3 06/15] iecm: Implement mailbox functionality > > On Thu, 25 Jun 2020 19:07:28 -0700 Jeff Kirsher wrote: > &

Re: [net-next v3 06/15] iecm: Implement mailbox functionality

2020-06-26 Thread Joe Perches
dhat.com; sassm...@redhat.com; Brady, Alan > > ; Burra, Phani R ; Hay, > > Joshua A ; Chittim, Madhu > > ; Linga, Pavan Kumar > > ; Skidmore, Donald C > > ; Brandeburg, Jesse > > ; Samudrala, Sridhar > > > > Subject: Re: [net-next v3 06/15] iecm: Impl

Re: [net-next v3 06/15] iecm: Implement mailbox functionality

2020-06-26 Thread Jakub Kicinski
On Thu, 25 Jun 2020 19:07:28 -0700 Jeff Kirsher wrote: > + err = register_netdev(netdev); > + if (err) > + return err; So the unregister_netdevice() call is in the previous patch, but registering it is apparetnly in the "implement mbox" patch... > + /* carrier off on init

RE: [net-next v3 06/15] iecm: Implement mailbox functionality

2020-06-26 Thread Brady, Alan
oshua A ; Chittim, Madhu > ; Linga, Pavan Kumar > ; Skidmore, Donald C > ; Brandeburg, Jesse > ; Samudrala, Sridhar > > Subject: Re: [net-next v3 06/15] iecm: Implement mailbox functionality > > On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > > From: Alice Mi

Re: [net-next v3 06/15] iecm: Implement mailbox functionality

2020-06-25 Thread Joe Perches
On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > From: Alice Michael > > Implement mailbox setup, take down, and commands. [] > diff --git a/drivers/net/ethernet/intel/iecm/iecm_controlq.c > b/drivers/net/ethernet/intel/iecm/iecm_controlq.c [] > @@ -73,7 +142,74 @@ enum iecm_status iecm_