On Thu, 25 Jun 2020 19:07:28 -0700 Jeff Kirsher wrote: > + err = register_netdev(netdev); > + if (err) > + return err;
So the unregister_netdevice() call is in the previous patch, but registering it is apparetnly in the "implement mbox" patch... > + /* carrier off on init to avoid Tx hangs */ > + netif_carrier_off(netdev); > + > + /* make sure transmit queues start off as stopped */ > + netif_tx_stop_all_queues(netdev); Seems like a bad idea to turn the carrier off and stop queues _after_ the netdev is registered. That's a very basic thing to pass 6 authors and 3 reviewers. What am I missing?
