Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-20 Thread Sekhar Nori
On Thursday 19 October 2017 08:25 PM, Marc Kleine-Budde wrote: > On 10/19/2017 03:54 PM, Franklin S Cooper Jr wrote: >> On 10/19/2017 06:32 AM, Marc Kleine-Budde wrote: >>> On 10/19/2017 01:09 PM, Sekhar Nori wrote: On Thursday 19 October 2017 02:43 PM, Marc Kleine-Budde wrote: > On 10/19/

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Oliver Hartkopp
On 10/19/2017 09:54 PM, Mario Hüttel wrote: On 10/19/2017 08:35 PM, Oliver Hartkopp wrote: We already have this 'dsample-point' implemented in the ip tool: $ ip link set vcan0 type can help Usage: ip link set DEVICE type can [ bitrate BITRATE [ sample-point SAMPLE-POINT] ] | [ tq TQ

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Mario Hüttel
On 10/19/2017 08:35 PM, Oliver Hartkopp wrote: > Hi Marc, > > On 10/19/2017 01:26 PM, Marc Kleine-Budde wrote: >> On 10/19/2017 01:14 PM, Oliver Hartkopp wrote: >>> Since we have a netlink socket interface to configure sample >>> point, I >>> wonder if that should be extended to config

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Oliver Hartkopp
Hi Marc, On 10/19/2017 01:26 PM, Marc Kleine-Budde wrote: On 10/19/2017 01:14 PM, Oliver Hartkopp wrote: Since we have a netlink socket interface to configure sample point, I wonder if that should be extended to configure SSP too (or at least the offset part of SSP)? +1 too The struct can_b

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Franklin S Cooper Jr
On 10/19/2017 09:55 AM, Marc Kleine-Budde wrote: > On 10/19/2017 03:54 PM, Franklin S Cooper Jr wrote: >> On 10/19/2017 06:32 AM, Marc Kleine-Budde wrote: >>> On 10/19/2017 01:09 PM, Sekhar Nori wrote: On Thursday 19 October 2017 02:43 PM, Marc Kleine-Budde wrote: > On 10/19/2017 07:07 A

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Marc Kleine-Budde
On 10/19/2017 03:54 PM, Franklin S Cooper Jr wrote: > On 10/19/2017 06:32 AM, Marc Kleine-Budde wrote: >> On 10/19/2017 01:09 PM, Sekhar Nori wrote: >>> On Thursday 19 October 2017 02:43 PM, Marc Kleine-Budde wrote: On 10/19/2017 07:07 AM, Sekhar Nori wrote: Sounds reasonable. What's

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Franklin S Cooper Jr
On 10/19/2017 06:32 AM, Marc Kleine-Budde wrote: > On 10/19/2017 01:09 PM, Sekhar Nori wrote: >> On Thursday 19 October 2017 02:43 PM, Marc Kleine-Budde wrote: >>> On 10/19/2017 07:07 AM, Sekhar Nori wrote: >>> Sounds reasonable. What's the status of this series? >> >> I have had some

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Marc Kleine-Budde
On 10/19/2017 01:09 PM, Sekhar Nori wrote: > On Thursday 19 October 2017 02:43 PM, Marc Kleine-Budde wrote: >> On 10/19/2017 07:07 AM, Sekhar Nori wrote: >> Sounds reasonable. What's the status of this series? > > I have had some offline discussions with Franklin on this, and I am not >

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Marc Kleine-Budde
On 10/19/2017 01:14 PM, Oliver Hartkopp wrote: > Since we have a netlink socket interface to configure sample point, I > wonder if that should be extended to configure SSP too (or at least the > offset part of SSP)? > > +1 too The struct can_bittiming in defined in uapi, so we have to

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Oliver Hartkopp
On 10/19/2017 11:13 AM, Marc Kleine-Budde wrote: On 10/19/2017 07:07 AM, Sekhar Nori wrote: Since we have a netlink socket interface to configure sample point, I wonder if that should be extended to configure SSP too (or at least the offset part of SSP)? +1 too Sekhar is right that ideal

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Sekhar Nori
On Thursday 19 October 2017 02:43 PM, Marc Kleine-Budde wrote: > On 10/19/2017 07:07 AM, Sekhar Nori wrote: > Sounds reasonable. What's the status of this series? I have had some offline discussions with Franklin on this, and I am not fully convinced that DT is the way to go here

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Marc Kleine-Budde
On 10/19/2017 10:04 AM, Ramesh Shanmugasundaram wrote: >>> Sounds reasonable. What's the status of this series? >> >> I have had some offline discussions with Franklin on this, and I am not >> fully convinced that DT is the way to go here (although I don't have the >> agreement with Franklin there)

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Marc Kleine-Budde
On 10/19/2017 07:07 AM, Sekhar Nori wrote: Sounds reasonable. What's the status of this series? >>> >>> I have had some offline discussions with Franklin on this, and I am not >>> fully convinced that DT is the way to go here (although I don't have the >>> agreement with Franklin there). >> >>

RE: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Ramesh Shanmugasundaram
> >>> On 08/18/2017 02:39 PM, Franklin S Cooper Jr wrote: > During test transmitting using CAN-FD at high bitrates (4 Mbps) > only resulted in errors. Scoping the signals I noticed that > only a single bit was being transmitted and with a bit more > investiga

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-18 Thread Sekhar Nori
On Wednesday 18 October 2017 07:47 PM, Franklin S Cooper Jr wrote: > > > On 10/18/2017 08:24 AM, Sekhar Nori wrote: >> Hi Marc, >> >> On Wednesday 18 October 2017 06:14 PM, Marc Kleine-Budde wrote: >>> On 09/21/2017 02:48 AM, Franklin S Cooper Jr wrote: On 09/20/2017 04:37 PM, Mari

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-18 Thread Franklin S Cooper Jr
On 10/18/2017 08:24 AM, Sekhar Nori wrote: > Hi Marc, > > On Wednesday 18 October 2017 06:14 PM, Marc Kleine-Budde wrote: >> On 09/21/2017 02:48 AM, Franklin S Cooper Jr wrote: >>> >>> >>> On 09/20/2017 04:37 PM, Mario Hüttel wrote: On 09/20/2017 10:19 PM, Franklin S Cooper Jr wro

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-18 Thread Sekhar Nori
Hi Marc, On Wednesday 18 October 2017 06:14 PM, Marc Kleine-Budde wrote: > On 09/21/2017 02:48 AM, Franklin S Cooper Jr wrote: >> >> >> On 09/20/2017 04:37 PM, Mario Hüttel wrote: >>> >>> >>> On 09/20/2017 10:19 PM, Franklin S Cooper Jr wrote: Hi Wenyou, On 09/17/2017 10:47 PM, Yang

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-18 Thread Marc Kleine-Budde
On 09/21/2017 02:48 AM, Franklin S Cooper Jr wrote: > > > On 09/20/2017 04:37 PM, Mario Hüttel wrote: >> >> >> On 09/20/2017 10:19 PM, Franklin S Cooper Jr wrote: >>> Hi Wenyou, >>> >>> On 09/17/2017 10:47 PM, Yang, Wenyou wrote: On 2017/9/14 13:06, Sekhar Nori wrote: > On Thursday

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-09-20 Thread Franklin S Cooper Jr
On 09/20/2017 04:37 PM, Mario Hüttel wrote: > > > On 09/20/2017 10:19 PM, Franklin S Cooper Jr wrote: >> Hi Wenyou, >> >> On 09/17/2017 10:47 PM, Yang, Wenyou wrote: >>> >>> On 2017/9/14 13:06, Sekhar Nori wrote: On Thursday 14 September 2017 03:28 AM, Franklin S Cooper Jr wrote: > On

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-09-20 Thread Mario Hüttel
On 09/20/2017 10:19 PM, Franklin S Cooper Jr wrote: > Hi Wenyou, > > On 09/17/2017 10:47 PM, Yang, Wenyou wrote: >> >> On 2017/9/14 13:06, Sekhar Nori wrote: >>> On Thursday 14 September 2017 03:28 AM, Franklin S Cooper Jr wrote: On 08/18/2017 02:39 PM, Franklin S Cooper Jr wrote: > Duri

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-09-20 Thread Franklin S Cooper Jr
Hi Wenyou, On 09/17/2017 10:47 PM, Yang, Wenyou wrote: > > > On 2017/9/14 13:06, Sekhar Nori wrote: >> On Thursday 14 September 2017 03:28 AM, Franklin S Cooper Jr wrote: >>> >>> On 08/18/2017 02:39 PM, Franklin S Cooper Jr wrote: During test transmitting using CAN-FD at high bitrates (4 Mb

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-09-17 Thread Yang, Wenyou
On 2017/9/14 13:06, Sekhar Nori wrote: On Thursday 14 September 2017 03:28 AM, Franklin S Cooper Jr wrote: On 08/18/2017 02:39 PM, Franklin S Cooper Jr wrote: During test transmitting using CAN-FD at high bitrates (4 Mbps) only resulted in errors. Scoping the signals I noticed that only a si

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-09-13 Thread Sekhar Nori
On Thursday 14 September 2017 03:28 AM, Franklin S Cooper Jr wrote: > > > On 08/18/2017 02:39 PM, Franklin S Cooper Jr wrote: >> During test transmitting using CAN-FD at high bitrates (4 Mbps) only >> resulted in errors. Scoping the signals I noticed that only a single bit >> was being transmitt

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-09-13 Thread Franklin S Cooper Jr
On 08/18/2017 02:39 PM, Franklin S Cooper Jr wrote: > During test transmitting using CAN-FD at high bitrates (4 Mbps) only > resulted in errors. Scoping the signals I noticed that only a single bit > was being transmitted and with a bit more investigation realized the actual > MCAN IP would go ba