RE: [PATCH net-next 7/8] net: phy: Add Synopsys DesignWare XPCS MDIO module

2020-06-09 Thread Jose Abreu
From: Russell King - ARM Linux admin Date: Jun/05/2020, 18:10:34 (UTC+00:00) > This is incorrect - you should not mask the link partner's advertisement > with our advertisement like this; consider the table in 802.3 for > resolving the pause modes, where simply doing a bitwise-and operation > bet

Re: [PATCH net-next 7/8] net: phy: Add Synopsys DesignWare XPCS MDIO module

2020-06-05 Thread Russell King - ARM Linux admin
Hi Jose, I just tripped over a bug while grepping for something else and reading a bit of this driver: On Mon, Mar 09, 2020 at 09:36:26AM +0100, Jose Abreu wrote: > +static int xpcs_read_lpa(struct mdio_xpcs_args *xpcs, > + struct phylink_link_state *state) > +{ > + int r