RE: [PATCH net-next] sched: add dualpi2 scheduler module

2019-03-14 Thread Toke Høiland-Jørgensen
"Tilmans, Olivier (Nokia - BE/Antwerp)" writes: >> I noticed that there's an IPR disclosure filed at the IETF[0] claiming a >> patent on the algorithm. I'm curious if you know whether Nokia has an >> official position on the use of that patent in this implementation if it >> becomes part of the k

RE: [PATCH net-next] sched: add dualpi2 scheduler module

2019-03-14 Thread Tilmans, Olivier (Nokia - BE/Antwerp)
> I noticed that there's an IPR disclosure filed at the IETF[0] claiming a > patent on the algorithm. I'm curious if you know whether Nokia has an > official position on the use of that patent in this implementation if it > becomes part of the kernel? :) Hi Toke, My understanding is that the GPLv

Re: [PATCH net-next] sched: add dualpi2 scheduler module

2019-03-14 Thread Toke Høiland-Jørgensen
Olga Albisser writes: > DUALPI2 provides extremely low latency & loss to traffic that uses a > scalable congestion controller (e.g. L4S, DCTCP) without degrading the > performance of 'classic' traffic (e.g. Reno, Cubic etc.). It is intended > to be the reference implementation of the IETF's DualQ

Re: [PATCH net-next] sched: add dualpi2 scheduler module

2019-03-11 Thread kbuild test robot
Hi Olga, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Olga-Albisser/sched-add-dualpi2-scheduler-module/20190312-042220 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gnu-gcc (

Re: [PATCH net-next] sched: add dualpi2 scheduler module

2019-03-11 Thread Eric Dumazet
On 03/11/2019 09:03 AM, Eric Dumazet wrote: > > > On 03/11/2019 08:14 AM, Olga Albisser wrote: > >> + >> +static u32 get_ecn_field(struct sk_buff *skb) >> +{ >> +switch (skb->protocol) { > > tc_skb_protocol(skb) > >> +case cpu_to_be16(ETH_P_IP): > > Theoretically you have to use ps

Re: [PATCH net-next] sched: add dualpi2 scheduler module

2019-03-11 Thread Eric Dumazet
On 03/11/2019 09:00 AM, Olga Albisser wrote: > Hi Eric, > > I thought the window opened roughly a week ago, and would be open for another > week (since it's 2 weeks in total), have I misunderstood? Yes, you have misunderstood. When Linus opens his window, it is the time for maintainers to pu

Re: [PATCH net-next] sched: add dualpi2 scheduler module

2019-03-11 Thread Eric Dumazet
On 03/11/2019 08:14 AM, Olga Albisser wrote: > + > +static u32 get_ecn_field(struct sk_buff *skb) > +{ > + switch (skb->protocol) { tc_skb_protocol(skb) > + case cpu_to_be16(ETH_P_IP): Theoretically you have to use pskb_may_pull() before assuming network header is in the linear part

Re: [PATCH net-next] sched: add dualpi2 scheduler module

2019-03-11 Thread Eric Dumazet
FYI, net-next tree is currently closed. On 03/11/2019 08:14 AM, Olga Albisser wrote: > DUALPI2 provides extremely low latency & loss to traffic that uses a > scalable congestion controller (e.g. L4S, DCTCP) without degrading the > performance of 'classic' traffic (e.g. Reno, Cubic etc.). It is int