Hi Olga,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    
https://github.com/0day-ci/linux/commits/Olga-Albisser/sched-add-dualpi2-scheduler-module/20190312-042220
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.2.0 make.cross ARCH=m68k 

All errors (new ones prefixed by >>):

   net/sched/sch_dualpi2.c: In function 'dualpi2_dump_stats':
>> net/sched/sch_dualpi2.c:518:4: error: 'struct tc_dualpi2_xstats' has no 
>> member named 'avg_dq_rate'
      .avg_dq_rate = 0,
       ^~~~~~~~~~~

vim +518 net/sched/sch_dualpi2.c

   510  
   511  static int dualpi2_dump_stats(struct Qdisc *sch, struct gnet_dump *d)
   512  {
   513          struct dualpi2_sched_data *q = qdisc_priv(sch);
   514          struct tc_dualpi2_xstats st = {
   515                  .prob           = q->vars.prob,
   516                  .delay          = 
((u32)PSCHED_TICKS2NS(q->vars.qdelay)) /
   517                                     NSEC_PER_USEC,
 > 518                  .avg_dq_rate    = 0,
   519                  .packets_in     = q->stats.packets_in,
   520                  .overlimit      = q->stats.overlimit,
   521                  .maxq           = q->stats.maxq,
   522                  .dropped        = q->stats.dropped,
   523                  .ecn_mark       = q->stats.ecn_mark,
   524          };
   525  
   526          return gnet_stats_copy_app(d, &st, sizeof(st));
   527  }
   528  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to