RE: [PATCH] net: macb: add phy-handle support for the macb

2016-08-18 Thread Appana Durga Kedareswara Rao
Hi Andrew, Thanks for the review... > > > Agree with you my intention is if there is a MDIO bus on the > > device-tree The MAC driver should create PHY/MDIO devices using > of_mdiobus_register(). > > What you suggest is better, and is similar to what other drivers use. > > In order to

Re: [PATCH] net: macb: add phy-handle support for the macb

2016-08-16 Thread Andrew Lunn
> Agree with you my intention is if there is a MDIO bus on the device-tree > The MAC driver should create PHY/MDIO devices using of_mdiobus_register(). What you suggest is better, and is similar to what other drivers use. In order to keep backwards compatibility with phy nodes in the MAC node, yo

RE: [PATCH] net: macb: add phy-handle support for the macb

2016-08-16 Thread Appana Durga Kedareswara Rao
Hi David Miller, Thanks for the review... > > From: Kedareswara rao Appana > Date: Sat, 13 Aug 2016 15:31:49 +0530 > > > @@ -445,7 +445,13 @@ static int macb_mii_init(struct macb *bp) > > dev_set_drvdata(&bp->dev->dev, bp->mii_bus); > > > > np = bp->pdev->dev.of_node; > > - i

Re: [PATCH] net: macb: add phy-handle support for the macb

2016-08-14 Thread David Miller
From: Kedareswara rao Appana Date: Sat, 13 Aug 2016 15:31:49 +0530 > @@ -445,7 +445,13 @@ static int macb_mii_init(struct macb *bp) > dev_set_drvdata(&bp->dev->dev, bp->mii_bus); > > np = bp->pdev->dev.of_node; > - if (np) { > + np1 = of_get_parent(bp->phy_node); > + if