Hi Andrew,

        Thanks for the review...

> 
> > Agree with you my intention is if there is a MDIO bus on the
> > device-tree The MAC driver should create PHY/MDIO devices using
> of_mdiobus_register().
> 
> What you suggest is better, and is similar to what other drivers use.
> 
> In order to keep backwards compatibility with phy nodes in the MAC node, you
> have to do of_mdiobus_register() with the MAC node. However, please change
> the binding documentation to say this is deprecated, all phy nodes should be
> placed inside an mdio node.
> 
> Using some better variable names would also help. mac_np and mdio_np for
> example.

Ok sure will post v2 as you suggested...

Regards,
Kedar.

Reply via email to