> Hi Andrew/Heiner
>
>Thanks for the feedback. This
patch
> fixes a case where ndo_change_mtu function is provided but the callback
> function is not storing mtu to netdevice structure.
> Hi Murali
> At the moment, any driver which implements ndo_change_mtu
> Hi Andrew/Heiner
>
>Thanks for the feedback. This patch
> fixes a case where ndo_change_mtu function is provided but the callback
> function is not storing mtu to netdevice structure.
Hi Murali
At the moment, any driver which implements ndo_change_mtu MU
> Hi Andrew,
>Currently net/dsa/slave.c does not have
> ndo_change_mtu function. But shortly I will be submitting a separate
> patch outside this fix that has ndo_change_mtu function support added to
> DSA switch. As part of testing the newly added ndo_change_mtu funct
On 02.01.2019 00:36, Andrew Lunn wrote:
>>> Is there a .ndo_change_mtu callback, which does not assign a new mtu itself?
>>>
>> So far all drivers have to do it themselves. But IMO this is more a
>> workaround
>> for the core not doing it. It's something the core should do.
>> Now we can remove th
> > Is there a .ndo_change_mtu callback, which does not assign a new mtu itself?
> >
> So far all drivers have to do it themselves. But IMO this is more a workaround
> for the core not doing it. It's something the core should do.
> Now we can remove this from drivers.
Hi Heiner
I think somebody
On Tue, Jan 01, 2019 at 03:18:51PM +0530, Murali Krishna Policharla wrote:
> Hi Andrew,
>Currently net/dsa/slave.c does not have
> ndo_change_mtu function. But shortly I will be submitting a separate
> patch outside this fix that has ndo_change_mtu function support adde
From: Murali Krishna Policharla
Date: Tue, 1 Jan 2019 12:12:14 +0530
> Store newly configured mtu settings in the netdevice after mtu
> configuration is successful to the dsa switch.
>
> Fixes: 2315dc91a5 ("net: make dev_set_mtu() honor notification return code")
> Signed-off-by: Murali Krishna
: Fix to store new mtu setting in netdevice.
On Tue, Jan 01, 2019 at 12:12:14PM +0530, Murali Krishna Policharla wrote:
> Store newly configured mtu settings in the netdevice after mtu
> configuration is successful to the dsa switch.
Hi Murali
Please could you give more details. net/dsa/s
On 01.01.2019 08:54, Kirill Tkhai wrote:
> On 01.01.2019 09:42, Murali Krishna Policharla wrote:
>> Store newly configured mtu settings in the netdevice after mtu
>> configuration is successful to the dsa switch.
>>
>> Fixes: 2315dc91a5 ("net: make dev_set_mtu() honor notification return code")
>>
On 01.01.2019 07:42, Murali Krishna Policharla wrote:
> Store newly configured mtu settings in the netdevice after mtu
> configuration is successful to the dsa switch.
>
At first: good that this is fixed, so far each network driver
had to do the "dev->mtu = new_mtu" in its ndo_change_mtu
callback
On Tue, Jan 01, 2019 at 12:12:14PM +0530, Murali Krishna Policharla wrote:
> Store newly configured mtu settings in the netdevice after mtu
> configuration is successful to the dsa switch.
Hi Murali
Please could you give more details. net/dsa/slave.c does not have a
ndo_change_mtu function, so i
On 01.01.2019 09:42, Murali Krishna Policharla wrote:
> Store newly configured mtu settings in the netdevice after mtu
> configuration is successful to the dsa switch.
>
> Fixes: 2315dc91a5 ("net: make dev_set_mtu() honor notification return code")
> Signed-off-by: Murali Krishna Policharla
> Rev
12 matches
Mail list logo
