Re: IP1000 gigabit nic driver

2006-05-03 Thread David Vrabel
Pekka J Enberg wrote: > On Wed, 3 May 2006, Andrew Morton wrote: >> Please remember that to merge this we'll need a signed-off-by from the >> original developers. (That's not very gplish, but such is life). > > OK. Lets see if we can track one of them developers down. I see Craig > Rich's email

Re: IP1000 gigabit nic driver

2006-05-03 Thread Pekka J Enberg
On Wed, 3 May 2006, Andrew Morton wrote: > Please remember that to merge this we'll need a signed-off-by from the > original developers. (That's not very gplish, but such is life). OK. Lets see if we can track one of them developers down. I see Craig Rich's email (only email found in the origina

Re: IP1000 gigabit nic driver

2006-05-03 Thread Andrew Morton
On Mon, 01 May 2006 12:31:40 +0300 Pekka Enberg <[EMAIL PROTECTED]> wrote: > [PATCH] IP1000 Gigabit Ethernet device driver > > This is a cleaned up fork of the IP1000A device driver: > > http://www.icplus.com.tw/driver-pp-IP1000A.html Please remember that to merge this we'll need a signed-off

Re: IP1000 gigabit nic driver

2006-05-01 Thread David Vrabel
Lennert Buytenhek wrote: On Mon, May 01, 2006 at 10:38:47PM +0200, Francois Romieu wrote: -/* Minimum number of miliseconds used to toggle MDC clock during +/* Minimum number of nanoseconds used to toggle MDC clock during * MII/GMII register access. */ -#define IPG_PC_PHYCTRLWAIT

Re: IP1000 gigabit nic driver

2006-05-01 Thread Lennert Buytenhek
On Mon, May 01, 2006 at 10:38:47PM +0200, Francois Romieu wrote: > > -/* Minimum number of miliseconds used to toggle MDC clock during > > +/* Minimum number of nanoseconds used to toggle MDC clock during > > * MII/GMII register access. > > */ > > -#define IPG_PC_PHYCTRLWAIT

Re: IP1000 gigabit nic driver

2006-05-01 Thread Francois Romieu
David Vrabel <[EMAIL PROTECTED]> : [...] > It was clocking the MII management interface (MDC) at 500 Hz so each PHY > register access took some 130 ms, and many registers accesses were being > done on initialization. According to the datasheet, the maximum > frequency for MDC is 2.5 MHz. Delays ha

Re: IP1000 gigabit nic driver

2006-05-01 Thread David Gómez
Hi Pekka, On Apr 29 at 11:35:04, Pekka Enberg wrote: > No, I haven't. I don't have the hardware, so I can't test the driver. > Furthermore, there's plenty of stuff to fix before it's in any shape for > submission. If someone wants to give this patch a spin, I would love to > hear the results. The

Re: IP1000 gigabit nic driver

2006-05-01 Thread Pekka Enberg
Hi David, On Mon, 2006-05-01 at 12:32 +0100, David Vrabel wrote: > It was clocking the MII management interface (MDC) at 500 Hz so each PHY > register access took some 130 ms, and many registers accesses were being > done on initialization. According to the datasheet, the maximum > frequency for M

Re: IP1000 gigabit nic driver

2006-05-01 Thread David Vrabel
David Vrabel wrote: - something (PHY reset/auto negotiation?) takes 2-3 seconds and appears to be done with interrupts disabled. It was clocking the MII management interface (MDC) at 500 Hz so each PHY register access took some 130 ms, and many registers accesses were being done on i

Re: IP1000 gigabit nic driver

2006-05-01 Thread Pekka Enberg
On Mon, 2006-05-01 at 00:40 +0100, David Vrabel wrote: > Still pending. Also: > > - something (PHY reset/auto negotiation?) takes 2-3 seconds and >appears to be done with interrupts disabled. Are you seeing this at module initialization? Does Sysrq-t show anything useful?

Re: IP1000 gigabit nic driver

2006-05-01 Thread Pekka Enberg
On Mon, 2006-05-01 at 00:40 +0100, David Vrabel wrote: > Thanks for doing this Pekka. I've fixed up some stuff and given it some > brief testing on a 100BaseT network and it seems to work now. Thanks! I merged your stuff and pushed out an updated patch. Pekka [P

Re: IP1000 gigabit nic driver

2006-04-30 Thread David Vrabel
Pekka Enberg wrote: On Sat, 2006-04-29 at 14:21 +0200, David Gómez wrote: I already had it modified, just needed to create the patch... Anyway, have you submitted it to netdev? On Sat, 2006-04-29 at 23:35 +0300, Pekka Enberg wrote: No, I haven't. I don't have the hardware, so I can't test the

Re: IP1000 gigabit nic driver

2006-04-30 Thread Pekka Enberg
On Sat, 2006-04-29 at 14:21 +0200, David Gómez wrote: > > I already had it modified, just needed to create the patch... Anyway, > > have you submitted it to netdev? On Sat, 2006-04-29 at 23:35 +0300, Pekka Enberg wrote: > No, I haven't. I don't have the hardware, so I can't test the driver. > Furt

Re: IP1000 gigabit nic driver

2006-04-29 Thread Pekka Enberg
Hi David, On Sat, 2006-04-29 at 14:21 +0200, David Gómez wrote: > I already had it modified, just needed to create the patch... Anyway, > have you submitted it to netdev? No, I haven't. I don't have the hardware, so I can't test the driver. Furthermore, there's plenty of stuff to fix before it's

Re: IP1000 gigabit nic driver

2006-04-29 Thread David Vrabel
Pekka Enberg wrote: I ended up doing most of them myself [1]. Sorry :-) Are the datasheets public by the way? http://www.icplus.com.tw/Data/Datasheet/IP1000A-DS-R08-07052005.pdf 1. http://www.cs.helsinki.fi/u/penberg/linux/ip1000-driver.patch - To unsubscribe from this list: send the line

Re: IP1000 gigabit nic driver

2006-04-29 Thread David Gómez
Hi Pekka, On Apr 29 at 01:29:26, Pekka Enberg wrote: > I ended up doing most of them myself [1]. Sorry :-) Are the datasheets > public by the way? I already had it modified, just needed to create the patch... Anyway, have you submitted it to netdev? About the datasheets, i don't think so. The ic

Re: IP1000 gigabit nic driver

2006-04-29 Thread Arjan van de Ven
On Sat, 2006-04-29 at 13:29 +0300, Pekka Enberg wrote: > On Fri, 28 Apr 2006, David Gómezz wrote: > > > Ok, i could take care of that, and it's a good way of getting my hands > > > dirty with kernel programming ;). David, if it's ok to you i'll do the > > > cleanup thing. > > On Fri, 2006-04-28 at

Re: IP1000 gigabit nic driver

2006-04-29 Thread Pekka Enberg
On Fri, 28 Apr 2006, David Gómezz wrote: > > Ok, i could take care of that, and it's a good way of getting my hands > > dirty with kernel programming ;). David, if it's ok to you i'll do the > > cleanup thing. On Fri, 2006-04-28 at 14:59 +0300, Pekka J Enberg wrote: > Here are some suggestions for

Re: IP1000 gigabit nic driver

2006-04-28 Thread David Gómez
Hi Pekka, On Apr 28 at 02:59:01, Pekka J Enberg wrote: > Here are some suggestions for coding style cleanups: Couple of questions, > - Use dev_{dbg,err,info,warn} for logging Cannot, i need a "struct device" and most of the there's only access to a "struct net_device". Am i missing something?

Re: IP1000 gigabit nic driver

2006-04-28 Thread Ingo Oeser
Hi David, David Gómez wrote: > On Apr 28 at 01:58:04, Pekka Enberg wrote: > > Needs some serious coding style cleanup and conversion to proper 2.6 > > APIs for starters. > > Ok, i could take care of that, and it's a good way of getting my hands > dirty with kernel programming ;). David, if it's o

Re: IP1000 gigabit nic driver

2006-04-28 Thread Pekka J Enberg
Hi David, On Fri, 28 Apr 2006, David Gómezz wrote: > Ok, i could take care of that, and it's a good way of getting my hands > dirty with kernel programming ;). David, if it's ok to you i'll do the > cleanup thing. Here are some suggestions for coding style cleanups: - Use Lindet for initial fo

Re: IP1000 gigabit nic driver

2006-04-28 Thread Pekka J Enberg
On Apr 28 at 01:58:04, Pekka Enberg wrote: > > Needs some serious coding style cleanup and conversion to proper 2.6 > > APIs for starters. On Fri, 28 Apr 2006, David Gómezz wrote: > Ok, i could take care of that, and it's a good way of getting my hands > dirty with kernel programming ;). David, if

Re: IP1000 gigabit nic driver

2006-04-28 Thread David Gómez
Hi Pekka, On Apr 28 at 01:58:04, Pekka Enberg wrote: > Needs some serious coding style cleanup and conversion to proper 2.6 > APIs for starters. Ok, i could take care of that, and it's a good way of getting my hands dirty with kernel programming ;). David, if it's ok to you i'll do the cleanup th

Re: IP1000 gigabit nic driver

2006-04-28 Thread Pekka Enberg
On 4/28/06, David Gómez <[EMAIL PROTECTED]> wrote: > I could help. What things do you think need to be fixed before > submitting the driver? Needs some serious coding style cleanup and conversion to proper 2.6 APIs for starters. - To unsubscribe from this list: send the line "unsubscribe netdev" i

Re: IP1000 gigabit nic driver

2006-04-28 Thread David Gómez
Hi David, On Apr 27 at 11:26:07, David Vrabel wrote: > I finally got around to putting a 2nd NIC in my box that has one of this > chips and was going to start fixing the driver up and preparing it for > submission this weekend. Great! > Or I might try rewriting from scratch based on > the da

Re: IP1000 gigabit nic driver

2006-04-28 Thread David Gómez
Hi Francois, On Apr 27 at 08:56:27, Francois Romieu wrote: > /me goes to http://www.icplus.com.tw/driver-pp-IP1000A.html > > $ unzip -c IP1000A-Linux-driver-v2.09f.zip | grep MODULE_LICENSE > MODULE_LICENSE("GPL"); Thanks, i didn't notice it ;-) > It's a bit bloaty but it does not seem too

Re: IP1000 gigabit nic driver

2006-04-27 Thread David Vrabel
Francois Romieu wrote: David Gómez <[EMAIL PROTECTED]> : [...] Does anybody in this list know why the IP1000 driver is not included in the kernel ? Afaik the driver has never been submitted for inclusion. At least not on netdev@vger.kernel.org (hint, hint). [...] The card in question is: Su

Re: IP1000 gigabit nic driver

2006-04-27 Thread Francois Romieu
David G??mez <[EMAIL PROTECTED]> : [...] > Does anybody in this list know why the IP1000 driver is not > included in the kernel ? Afaik the driver has never been submitted for inclusion. At least not on netdev@vger.kernel.org (hint, hint). [...] > The card in question is: > > Sundance Technology