Hi David,
On Fri, 28 Apr 2006, David Gómezz wrote:
> Ok, i could take care of that, and it's a good way of getting my hands
> dirty with kernel programming ;). David, if it's ok to you i'll do the
> cleanup thing.
Here are some suggestions for coding style cleanups:
- Use Lindet for initial formatting
- Kill use of LINUX_VERSION_CODE macro for compatability
- Kill obfuscating macros. For example, IPG_DEV_KFREE_SKB and
IPG_DEVICE_TYPE.
- Move changelogs outside of source files
- Convert kmalloc/memset to kzalloc and kcalloc
- Remove redundant typecasts
- Remove dead code
- Use dev_{dbg,err,info,warn} for logging
- Remove unnecessary curly braces
- Use proper naming convention for things like Length and pPHYParam
- Convert macro functions to static inline functions for type safety
Pekka
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
