Re: Debugging neighbour.c: timers

2005-09-07 Thread Ben Greear
David S. Miller wrote: From: Ben Greear <[EMAIL PROTECTED]> Date: Wed, 07 Sep 2005 14:14:42 -0700 David S. Miller wrote: Doing an add_timer() for something already scheduled it fine. Does it actually cause a second timer to fire? If not, this would keep us from correctly decrementing the

Re: Debugging neighbour.c: timers

2005-09-07 Thread David S. Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Wed, 07 Sep 2005 14:14:42 -0700 > David S. Miller wrote: > > Doing an add_timer() for something already scheduled it fine. > > Does it actually cause a second timer to fire? If not, this > would keep us from correctly decrementing the reference count.

Re: Debugging neighbour.c: timers

2005-09-07 Thread Ben Greear
David S. Miller wrote: From: Ben Greear <[EMAIL PROTECTED]> Date: Wed, 07 Sep 2005 12:36:20 -0700 Thanks for catching that. A new patch is attached. I didn't see any printouts for this message even with the fix, so this case must not be hit (at least not often). Please let me know if you se

Re: Debugging neighbour.c: timers

2005-09-07 Thread David S. Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Wed, 07 Sep 2005 12:36:20 -0700 > Thanks for catching that. A new patch is attached. I didn't see any > printouts for this message even with the fix, so this case must not be > hit (at least not often). > > Please let me know if you see any more areas

Re: Debugging neighbour.c: timers

2005-09-07 Thread Ben Greear
Julian Anastasov wrote: Hello, On Wed, 7 Sep 2005, Ben Greear wrote: Ben Greear wrote: I added a separate flag to keep track of whether a neighbour struct is on the timer list or not. I also added some logic to dump the stack if the add-timer method was called while we are already

Re: Debugging neighbour.c: timers

2005-09-07 Thread Julian Anastasov
Hello, On Wed, 7 Sep 2005, Ben Greear wrote: > Ben Greear wrote: > > I added a separate flag to keep track of whether a neighbour struct > > is on the timer list or not. I also added some logic to dump the > > stack if the add-timer method was called while we are already on > > the time

Re: Debugging neighbour.c: timers

2005-09-07 Thread Ben Greear
Ben Greear wrote: I added a separate flag to keep track of whether a neighbour struct is on the timer list or not. I also added some logic to dump the stack if the add-timer method was called while we are already on the timer list. A cleaned up patch against 2.6.13 is attached. This (also) se

Debugging neighbour.c: timers

2005-09-06 Thread Ben Greear
I added a separate flag to keep track of whether a neighbour struct is on the timer list or not. I also added some logic to dump the stack if the add-timer method was called while we are already on the timer list. This dump-stack method is being called quite often in my test that used to reprodu