Re: [patch net-next v2 08/12] dsa: implement ndo_get_devlink_port

2019-03-27 Thread Jiri Pirko
Wed, Mar 27, 2019 at 09:13:00PM CET, f.faine...@gmail.com wrote: >On 3/27/19 1:01 PM, Jiri Pirko wrote: >> Wed, Mar 27, 2019 at 08:54:41PM CET, f.faine...@gmail.com wrote: >>> On 3/26/2019 5:03 AM, Jiri Pirko wrote: From: Jiri Pirko In order for devlink compat functions to work, imp

Re: [patch net-next v2 08/12] dsa: implement ndo_get_devlink_port

2019-03-27 Thread Florian Fainelli
On 3/27/19 1:01 PM, Jiri Pirko wrote: > Wed, Mar 27, 2019 at 08:54:41PM CET, f.faine...@gmail.com wrote: >> On 3/26/2019 5:03 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> In order for devlink compat functions to work, implement >>> ndo_get_devlink_port. Legacy slaves does not have devlink po

Re: [patch net-next v2 08/12] dsa: implement ndo_get_devlink_port

2019-03-27 Thread Jiri Pirko
Wed, Mar 27, 2019 at 08:54:41PM CET, f.faine...@gmail.com wrote: >On 3/26/2019 5:03 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> In order for devlink compat functions to work, implement >> ndo_get_devlink_port. Legacy slaves does not have devlink port instances >> created for themselves. > >No

Re: [patch net-next v2 08/12] dsa: implement ndo_get_devlink_port

2019-03-27 Thread Florian Fainelli
On 3/26/2019 5:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > In order for devlink compat functions to work, implement > ndo_get_devlink_port. Legacy slaves does not have devlink port instances > created for themselves. Not a big fan of de-duplicating the entire set of netdev_ops for legacy vs.

[patch net-next v2 08/12] dsa: implement ndo_get_devlink_port

2019-03-26 Thread Jiri Pirko
From: Jiri Pirko In order for devlink compat functions to work, implement ndo_get_devlink_port. Legacy slaves does not have devlink port instances created for themselves. Signed-off-by: Jiri Pirko --- v1->v2: - new patch --- net/dsa/dsa_priv.h | 1 + net/dsa/legacy.c | 2 +- net/dsa/slave.