Wed, Mar 27, 2019 at 08:54:41PM CET, f.faine...@gmail.com wrote: >On 3/26/2019 5:03 AM, Jiri Pirko wrote: >> From: Jiri Pirko <j...@mellanox.com> >> >> In order for devlink compat functions to work, implement >> ndo_get_devlink_port. Legacy slaves does not have devlink port instances >> created for themselves. > >Not a big fan of de-duplicating the entire set of netdev_ops for legacy >vs. non-legacy, can we just check that the devlink instance was r
In nfp, I make legacy and non-legacy ndos to be shared. However there, they are doing to eventually all use devlink ports. In dsa on the other hand, I don't think that legacy is going to use devlink port, would it? I wan't to eventually have WARN_ON in devlink code in case devlink_port exists and phys_port_name ndo is present at the same time.
