Re: [patch net-next 1/2] devlink: add hardware messages tracing facility

2016-07-12 Thread Jiri Pirko
Tue, Jul 12, 2016 at 02:44:17PM CEST, rost...@goodmis.org wrote: >On Tue, 12 Jul 2016 10:38:37 +0200 >Jiri Pirko wrote: > > >> Hmm, I'm trying to make it work this was but it seems to be a bit more >> complicated. I did not find any code doing this (having the tracepoint >> compiled in or not) so

Re: [patch net-next 1/2] devlink: add hardware messages tracing facility

2016-07-12 Thread Steven Rostedt
On Tue, 12 Jul 2016 10:38:37 +0200 Jiri Pirko wrote: > Hmm, I'm trying to make it work this was but it seems to be a bit more > complicated. I did not find any code doing this (having the tracepoint > compiled in or not) so I cannot copy&paste the solution. > > The problem is that trace_devlink

Re: [patch net-next 1/2] devlink: add hardware messages tracing facility

2016-07-12 Thread Jiri Pirko
Mon, Jul 11, 2016 at 06:08:14PM CEST, rost...@goodmis.org wrote: >On Mon, 11 Jul 2016 15:18:47 +0200 >Jiri Pirko wrote: > >> From: Jiri Pirko >> >> Define a tracepoint and allow user to trace messages going to and from >> hardware associated with devlink instance. >> >> Signed-off-by: Jiri Pirk

Re: [patch net-next 1/2] devlink: add hardware messages tracing facility

2016-07-11 Thread Jiri Pirko
Mon, Jul 11, 2016 at 10:54:12PM CEST, rost...@goodmis.org wrote: >On Mon, 11 Jul 2016 15:18:47 +0200 >Jiri Pirko wrote: > >> diff --git a/include/net/devlink.h b/include/net/devlink.h >> index c99ffe8..865ade6 100644 >> --- a/include/net/devlink.h >> +++ b/include/net/devlink.h >> @@ -115,6 +115,8

Re: [patch net-next 1/2] devlink: add hardware messages tracing facility

2016-07-11 Thread Jiri Pirko
Mon, Jul 11, 2016 at 10:45:16PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 11 Jul 2016 15:18:47 +0200 > >> From: Jiri Pirko >> >> Define a tracepoint and allow user to trace messages going to and from >> hardware associated with devlink instance. >> >> Signed-off-by: Jiri Pi

Re: [patch net-next 1/2] devlink: add hardware messages tracing facility

2016-07-11 Thread Steven Rostedt
On Mon, 11 Jul 2016 15:18:47 +0200 Jiri Pirko wrote: > diff --git a/include/net/devlink.h b/include/net/devlink.h > index c99ffe8..865ade6 100644 > --- a/include/net/devlink.h > +++ b/include/net/devlink.h > @@ -115,6 +115,8 @@ struct devlink *devlink_alloc(const struct devlink_ops > *ops, size_

Re: [patch net-next 1/2] devlink: add hardware messages tracing facility

2016-07-11 Thread David Miller
From: Jiri Pirko Date: Mon, 11 Jul 2016 15:18:47 +0200 > From: Jiri Pirko > > Define a tracepoint and allow user to trace messages going to and from > hardware associated with devlink instance. > > Signed-off-by: Jiri Pirko Jiri, I don't think "having a devlink_ prefix" is a strong enough ar

Re: [patch net-next 1/2] devlink: add hardware messages tracing facility

2016-07-11 Thread Jiri Pirko
Mon, Jul 11, 2016 at 06:08:14PM CEST, rost...@goodmis.org wrote: >On Mon, 11 Jul 2016 15:18:47 +0200 >Jiri Pirko wrote: > >> From: Jiri Pirko >> >> Define a tracepoint and allow user to trace messages going to and from >> hardware associated with devlink instance. >> >> Signed-off-by: Jiri Pirk

Re: [patch net-next 1/2] devlink: add hardware messages tracing facility

2016-07-11 Thread Steven Rostedt
On Mon, 11 Jul 2016 15:18:47 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > Define a tracepoint and allow user to trace messages going to and from > hardware associated with devlink instance. > > Signed-off-by: Jiri Pirko > --- > include/net/devlink.h | 8 +++ > include/trace/e

Re: [patch net-next 1/2] devlink: add hardware messages tracing facility

2016-07-11 Thread Jiri Pirko
Mon, Jul 11, 2016 at 05:01:46PM CEST, d...@cumulusnetworks.com wrote: >On 7/11/16 7:18 AM, Jiri Pirko wrote: > >>diff --git a/net/core/devlink.c b/net/core/devlink.c >>index b2e592a..8cfa3b0 100644 >>--- a/net/core/devlink.c >>+++ b/net/core/devlink.c >>@@ -26,6 +26,8 @@ >> #include >> #include >

Re: [patch net-next 1/2] devlink: add hardware messages tracing facility

2016-07-11 Thread David Ahern
On 7/11/16 7:18 AM, Jiri Pirko wrote: diff --git a/net/core/devlink.c b/net/core/devlink.c index b2e592a..8cfa3b0 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -26,6 +26,8 @@ #include #include #include +#define CREATE_TRACE_POINTS +#include EXPORT_TRACEPOINT_SYMBOL_GPL(tra

[patch net-next 1/2] devlink: add hardware messages tracing facility

2016-07-11 Thread Jiri Pirko
From: Jiri Pirko Define a tracepoint and allow user to trace messages going to and from hardware associated with devlink instance. Signed-off-by: Jiri Pirko --- include/net/devlink.h | 8 +++ include/trace/events/devlink.h | 49 ++ net/core