Re: [patch 03/14] e1000: omit stats for broken counter in 82543

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: omit stats for broken counter in 82543 From: Jesse Brandeburg <[EMAIL PROTECTED]> The 82543 chip does not count tx_carrier_errors properly in FD mode; report zeros instead of garbage. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke

Re: [patch 03/14] e1000: omit stats for broken counter in 82543

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Jeff Garzik wrote: Needs to use an "i have broken stats" feature flag, rather than adding yet another mac_type test into the code. This testing of MAC type rather than feature flags is a major e1000 problem, and it bloats the driver quite a bit. Intel has been told fo

Re: [patch 03/14] e1000: omit stats for broken counter in 82543

2006-12-15 Thread Arjan van de Ven
Jeff Garzik wrote: Needs to use an "i have broken stats" feature flag, rather than adding yet another mac_type test into the code. This testing of MAC type rather than feature flags is a major e1000 problem, and it bloats the driver quite a bit. Intel has been told for /months/ this is a prob

Re: [patch 03/14] e1000: omit stats for broken counter in 82543

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: omit stats for broken counter in 82543 From: Jesse Brandeburg <[EMAIL PROTECTED]> The 82543 chip does not count tx_carrier_errors properly in FD mode; report zeros instead of garbage. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke

[patch 03/14] e1000: omit stats for broken counter in 82543

2006-12-15 Thread Arjan van de Ven
Subject: e1000: omit stats for broken counter in 82543 From: Jesse Brandeburg <[EMAIL PROTECTED]> The 82543 chip does not count tx_carrier_errors properly in FD mode; report zeros instead of garbage. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> S