Arjan van de Ven wrote:
Subject: e1000: omit stats for broken counter in 82543
From: Jesse Brandeburg <[EMAIL PROTECTED]>
The 82543 chip does not count tx_carrier_errors properly in FD mode;
report zeros instead of garbage.
Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
Signed-off-by: Arjan van de Ven <[EMAIL PROTECTED]>
---
drivers/net/e1000/e1000_main.c | 5 +++++
1 file changed, 5 insertions(+), 0 deletion(-)
Index: linux-2.6/drivers/net/e1000/e1000_main.c
===================================================================
--- linux-2.6.orig/drivers/net/e1000/e1000_main.c
+++ linux-2.6/drivers/net/e1000/e1000_main.c
@@ -3580,7 +3580,12 @@ e1000_update_stats(struct e1000_adapter
adapter->net_stats.tx_errors = adapter->stats.txerrc;
adapter->net_stats.tx_aborted_errors = adapter->stats.ecol;
adapter->net_stats.tx_window_errors = adapter->stats.latecol;
adapter->net_stats.tx_carrier_errors = adapter->stats.tncrs;
+ if (adapter->hw.mac_type == e1000_82543 &&
+ adapter->link_duplex == FULL_DUPLEX) {
+ adapter->net_stats.tx_carrier_errors = 0;
+ adapter->stats.tncrs = 0;
+ }
Needs to use an "i have broken stats" feature flag, rather than adding
yet another mac_type test into the code. This testing of MAC type
rather than feature flags is a major e1000 problem, and it bloats the
driver quite a bit. Intel has been told for /months/ this is a problem,
yet I still see patches like this.
This is one of the comments I sent to Auke.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
