Re: [patch] tcp: attach SYNACK messages to request sockets instead of listener

2015-10-30 Thread Eric Dumazet
On Fri, 2015-10-30 at 21:42 +, Haiyang Zhang wrote: > > > With your 2nd patch, I saw: > [ 19.242104] Wow ! headroom=164 while hh_len(eth0)=240 > > After adding the 3rd patch with increased LL_MAX_HEADER, > the warning and stack trace no longer show up. > > Also, could you fix the net cor

RE: [patch] tcp: attach SYNACK messages to request sockets instead of listener

2015-10-30 Thread Haiyang Zhang
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Friday, October 30, 2015 4:19 PM > To: Haiyang Zhang > Cc: eduma...@google.com; David Miller ; > netdev@vger.kernel.org; KY Srinivasan > Subject: Re: [patch] tcp: attach SYNACK messag

RE: [patch] tcp: attach SYNACK messages to request sockets instead of listener

2015-10-30 Thread KY Srinivasan
> > To: Haiyang Zhang > > > Cc: eduma...@google.com; David Miller ; > > > netdev@vger.kernel.org; KY Srinivasan > > > Subject: Re: [patch] tcp: attach SYNACK messages to request sockets > > > instead of listener > > > > > > > &

Re: [patch] tcp: attach SYNACK messages to request sockets instead of listener

2015-10-30 Thread Eric Dumazet
On Fri, 2015-10-30 at 13:02 -0700, Eric Dumazet wrote: > So it looks like you have a device with a very big hh_len > > MAX_TCP_HEADER is not enough space to hold all headers, and this is the > bug that needs to be fixed. This is scary to realloc all tcp packets ! > drivers/net/hyperv/netvsc_drv

Re: [patch] tcp: attach SYNACK messages to request sockets instead of listener

2015-10-30 Thread Eric Dumazet
; netdev@vger.kernel.org; KY Srinivasan > > Subject: Re: [patch] tcp: attach SYNACK messages to request sockets > > instead of listener > > > > > > Thanks for this report. > > > > Somehow I knew such bugs would surface ;) > > > > Please tr

RE: [patch] tcp: attach SYNACK messages to request sockets instead of listener

2015-10-30 Thread Haiyang Zhang
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Thursday, October 29, 2015 6:59 PM > To: Haiyang Zhang > Cc: eduma...@google.com; David Miller ; > netdev@vger.kernel.org; KY Srinivasan > Subject: Re: [patch] tcp: attach SYNAC

Re: [patch] tcp: attach SYNACK messages to request sockets instead of listener

2015-10-29 Thread Eric Dumazet
f9b65dc0aac02ff97704d52a05 (patch) > tcp: attach SYNACK messages to request sockets instead of listener > > Stack trace: > [ 96.235084] general protection fault: [#1] SMP > [ 96.235084] Modules linked in: ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 > ipt_REJECT nf_rej

Re: [patch] tcp: attach SYNACK messages to request sockets instead of listener

2015-10-29 Thread Haiyang Zhang
? http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=ca6fb06518836ef9b65dc0aac02ff97704d52a05 author Eric Dumazet 2015-10-02 18:43:35 (GMT) commit ca6fb06518836ef9b65dc0aac02ff97704d52a05 (patch) tcp: attach SYNACK messages to request sockets instead of listener Stack