Re: [patch, -rc5-mm1] lock validator: remove softirq.c WARN_ON

2006-05-30 Thread Alexey Kuznetsov
Hello! > > static void netlink_table_grab(void) > > { > > write_lock_bh(&nl_table_lock); > > well it could be this one as well... Indeed. But it still looks as something very strange. There are some GFP_KERNEL allocations on the way to this function. - To unsubscribe from this list: sen

Re: [patch, -rc5-mm1] lock validator: remove softirq.c WARN_ON

2006-05-30 Thread Arjan van de Ven
On Tue, 2006-05-30 at 20:00 +0400, Alexey Kuznetsov wrote: > Hello! > > > ok, that WARN_ON is over-eager. Fix is below: > > Nevertheless, I cannot figure out what's happening here. > > This local_bh_disable() is called right after schedule(). > No way irqs can be disabled there. What is wrong? >

Re: [patch, -rc5-mm1] lock validator: remove softirq.c WARN_ON

2006-05-30 Thread Alexey Kuznetsov
Hello! > ok, that WARN_ON is over-eager. Fix is below: Nevertheless, I cannot figure out what's happening here. This local_bh_disable() is called right after schedule(). No way irqs can be disabled there. What is wrong? static void netlink_table_grab(void) { write_lock_bh(&nl_table_loc

[patch, -rc5-mm1] lock validator: remove softirq.c WARN_ON

2006-05-30 Thread Ingo Molnar
* Jiri Slaby <[EMAIL PROTECTED]> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Andrew Morton napsal(a): > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17-rc5/2.6.17-rc5-mm1/ > > BUG: warning at /l/latest/xxx/kernel/softirq.c:86/local_bh_disable() ok, that