* Jiri Slaby <[EMAIL PROTECTED]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Andrew Morton napsal(a): > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17-rc5/2.6.17-rc5-mm1/ > > BUG: warning at /l/latest/xxx/kernel/softirq.c:86/local_bh_disable()
ok, that WARN_ON is over-eager. Fix is below: -------------- Subject: lock validator: remove softirq.c WARN_ON From: Ingo Molnar <[EMAIL PROTECTED]> there is nothing wrong with calling local_bh_disable() in irqs-off section (as long as the local_bh_enable isnt done with irqs-off), so remove this over-eager WARN_ON(). Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Signed-off-by: Arjan van de Ven <[EMAIL PROTECTED]> --- kernel/softirq.c | 1 - 1 file changed, 1 deletion(-) Index: linux/kernel/softirq.c =================================================================== --- linux.orig/kernel/softirq.c +++ linux/kernel/softirq.c @@ -83,7 +83,6 @@ static void __local_bh_disable(unsigned void local_bh_disable(void) { - WARN_ON_ONCE(irqs_disabled()); __local_bh_disable((unsigned long)__builtin_return_address(0)); } - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html