r...@redhat.com; sassm...@redhat.com; Brown, Aaron F
> >
> > Subject: Re: [net-next v5 4/9] igc: Use netdev log helpers in igc_ethtool.c
> >
> > On Mon, 2020-05-18 at 18:03 -0700, Jeff Kirsher wrote:
> > > This patch converts all dev_* calls to netdev_*.
> >
> -Original Message-
> From: Joe Perches
> Sent: Monday, May 18, 2020 18:22
> To: Kirsher, Jeffrey T ; da...@davemloft.net
> Cc: Guedes, Andre ; netdev@vger.kernel.org;
> nhor...@redhat.com; sassm...@redhat.com; Brown, Aaron F
>
> Subject: Re: [net-next v5
On Mon, 2020-05-18 at 18:03 -0700, Jeff Kirsher wrote:
> This patch converts all dev_* calls to netdev_*.
[]
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> b/drivers/net/ethernet/intel/igc/igc_ethtool.c
[]
> @@ -1904,7 +1905,7 @@ static void igc_diag_test(struct net_device *netdev,
From: Andre Guedes
In igc_ethtool.c we print log messages using dev_* helpers, generating
inconsistent output with the rest of the driver. Since this is a network
device driver, we should preferably use netdev_* helpers because they
append the interface name to the message, helping making sense t
