> -----Original Message----- > From: Joe Perches <[email protected]> > Sent: Monday, May 18, 2020 18:22 > To: Kirsher, Jeffrey T <[email protected]>; [email protected] > Cc: Guedes, Andre <[email protected]>; [email protected]; > [email protected]; [email protected]; Brown, Aaron F > <[email protected]> > Subject: Re: [net-next v5 4/9] igc: Use netdev log helpers in igc_ethtool.c > > On Mon, 2020-05-18 at 18:03 -0700, Jeff Kirsher wrote: > > This patch converts all dev_* calls to netdev_*. > [] > > diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c > > b/drivers/net/ethernet/intel/igc/igc_ethtool.c > [] > > @@ -1904,7 +1905,7 @@ static void igc_diag_test(struct net_device > *netdev, > > bool if_running = netif_running(netdev); > > > > if (eth_test->flags == ETH_TEST_FL_OFFLINE) { > > - netdev_info(adapter->netdev, "offline testing starting"); > > + netdev_info(adapter->netdev, "Offline testing starting"); > > several missing '\n' format terminations [Kirsher, Jeffrey T]
Your right, these never had them, which is why it was not caught. I am fine with adding the terminating \n, if that is what is requested. Andre was just trying to fix the message to properly capitalize the first letter of the message. > > netdev_info(adapter->netdev, "Offline testing starting\n"); > > > set_bit(__IGC_TESTING, &adapter->state); > > > > /* Link test performed before hardware reset so autoneg doesn't > @@ > > -1918,13 +1919,13 @@ static void igc_diag_test(struct net_device *netdev, > > else > > igc_reset(adapter); > > > > - netdev_info(adapter->netdev, "register testing starting"); > > + netdev_info(adapter->netdev, "Register testing starting"); > > etc... [Kirsher, Jeffrey T] Yep here too
