RE: [net-next v2 1/8] net-zerocopy: Copy straggler unaligned data for TCP Rx. zerocopy.

2020-12-04 Thread David Laight
From: Eric > Sent: 03 December 2020 23:15 > > On Fri, Dec 4, 2020 at 12:01 AM David Laight wrote: > > > > From: Stephen Hemminger > > > Sent: 03 December 2020 00:15 > > > > > > On Wed, 2 Dec 2020 14:09:38 -0800 > > > Arjun Roy wrote: > > > > > > > diff --git a/include/uapi/linux/tcp.h b/include

RE: [net-next v2 1/8] net-zerocopy: Copy straggler unaligned data for TCP Rx. zerocopy.

2020-12-04 Thread David Laight
From: Arjun Roy > Sent: 03 December 2020 23:25 ... > > > You also have to allow for old (working) applications being recompiled > > > with the new headers. > > > So you cannot rely on the fields being zero even if you are passed > > > the size of the structure. > > > > > > > I think this should alr

RE: [net-next v2 1/8] net-zerocopy: Copy straggler unaligned data for TCP Rx. zerocopy.

2020-12-03 Thread David Laight
From: Stephen Hemminger > Sent: 03 December 2020 00:15 > > On Wed, 2 Dec 2020 14:09:38 -0800 > Arjun Roy wrote: > > > diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h > > index cfcb10b75483..62db78b9c1a0 100644 > > --- a/include/uapi/linux/tcp.h > > +++ b/include/uapi/linux/tcp.

Re: [net-next v2 1/8] net-zerocopy: Copy straggler unaligned data for TCP Rx. zerocopy.

2020-12-02 Thread Stephen Hemminger
On Wed, 2 Dec 2020 14:09:38 -0800 Arjun Roy wrote: > diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h > index cfcb10b75483..62db78b9c1a0 100644 > --- a/include/uapi/linux/tcp.h > +++ b/include/uapi/linux/tcp.h > @@ -349,5 +349,7 @@ struct tcp_zerocopy_receive { > __u32 recv

[net-next v2 1/8] net-zerocopy: Copy straggler unaligned data for TCP Rx. zerocopy.

2020-12-02 Thread Arjun Roy
From: Arjun Roy When TCP receive zerocopy does not successfully map the entire requested space, it outputs a 'hint' that the caller should recvmsg(). Augment zerocopy to accept a user buffer that it tries to copy this hint into - if it is possible to copy the entire hint, it will do so. This eli