From: Eric
> Sent: 03 December 2020 23:15
>
> On Fri, Dec 4, 2020 at 12:01 AM David Laight <david.lai...@aculab.com> wrote:
> >
> > From: Stephen Hemminger
> > > Sent: 03 December 2020 00:15
> > >
> > > On Wed, 2 Dec 2020 14:09:38 -0800
> > > Arjun Roy <arjunroy.k...@gmail.com> wrote:
> > >
> > > > diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h
> > > > index cfcb10b75483..62db78b9c1a0 100644
> > > > --- a/include/uapi/linux/tcp.h
> > > > +++ b/include/uapi/linux/tcp.h
> > > > @@ -349,5 +349,7 @@ struct tcp_zerocopy_receive {
> > > > __u32 recv_skip_hint; /* out: amount of bytes to skip */
> > > > __u32 inq; /* out: amount of bytes in read queue */
> > > > __s32 err; /* out: socket error */
> > > > + __u64 copybuf_address; /* in: copybuf address (small reads) */
> > > > + __s32 copybuf_len; /* in/out: copybuf bytes avail/used or error */
> >
> > You need to swap the order of the above fields to avoid padding
> > and differing alignments for 32bit and 64bit apps.
>
> I do not think so. Please review this patch series carefully.
Late at night.
The actual problem is 'tail padding'.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT,
UK
Registration No: 1397386 (Wales)
