Re: [net-next v2 04/14] ice: fix set pause param autoneg check

2019-08-19 Thread David Miller
From: Jeff Kirsher Date: Mon, 19 Aug 2019 09:16:58 -0700 > + /* Get pause param reports configured and negotiated flow control pause > + * when ETHTOOL_GLINKSETTINGS is defined. Since ETHTOOL_GLINKSETTINGS is > + * defined get pause param pause->autoneg reports SW configured setting

Re: [net-next v2 04/14] ice: fix set pause param autoneg check

2019-08-19 Thread David Miller
From: Jakub Kicinski Date: Mon, 19 Aug 2019 16:11:42 -0700 > On Mon, 19 Aug 2019 09:16:58 -0700, Jeff Kirsher wrote: >> +pcaps = devm_kzalloc(&vsi->back->pdev->dev, sizeof(*pcaps), >> + GFP_KERNEL); >> +if (!pcaps) >> +return -ENOMEM; >> + >> +/* Ge

Re: [net-next v2 04/14] ice: fix set pause param autoneg check

2019-08-19 Thread Jakub Kicinski
On Mon, 19 Aug 2019 09:16:58 -0700, Jeff Kirsher wrote: > + pcaps = devm_kzalloc(&vsi->back->pdev->dev, sizeof(*pcaps), > + GFP_KERNEL); > + if (!pcaps) > + return -ENOMEM; > + > + /* Get current PHY config */ > + status = ice_aq_get_phy_caps(pi,

[net-next v2 04/14] ice: fix set pause param autoneg check

2019-08-19 Thread Jeff Kirsher
From: Paul Greenwalt When ETHTOOL_GLINKSETTINGS is defined get pause param pause->autoneg reports SW configured setting, however when not defined get pause param pause->autoneg reports the link status. Set pause param needs to compare pause->autoneg with the same source as get pause param to bloc