From: Jeff Kirsher <jeffrey.t.kirs...@intel.com> Date: Mon, 19 Aug 2019 09:16:58 -0700
> + /* Get pause param reports configured and negotiated flow control pause > + * when ETHTOOL_GLINKSETTINGS is defined. Since ETHTOOL_GLINKSETTINGS is > + * defined get pause param pause->autoneg reports SW configured setting, > + * so compare pause->autoneg with SW configured to prevent the user from > + * using set pause param to chance autoneg. > + */ > + pcaps = devm_kzalloc(&vsi->back->pdev->dev, sizeof(*pcaps), > + GFP_KERNEL); Just in case it isn't clear, please use plain kzalloc/kfree in this code. Thank you.