Re: [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe

2016-02-16 Thread John Fastabend
On 16-02-16 05:17 PM, David Miller wrote: > From: John Fastabend > Date: Mon, 15 Feb 2016 22:00:03 -0800 > >> This extends the setup_tc framework so it can support more than just >> the mqprio offload and push other classifiers and qdiscs into the >> hardware. > ... > > Jiri gave some minor sty

Re: [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe

2016-02-16 Thread David Miller
From: John Fastabend Date: Mon, 15 Feb 2016 22:00:03 -0800 > This extends the setup_tc framework so it can support more than just > the mqprio offload and push other classifiers and qdiscs into the > hardware. ... Jiri gave some minor stylistic feedback, please address that and respin, and I'll

Re: [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe

2016-02-16 Thread Or Gerlitz
On Tue, Feb 16, 2016 at 9:50 PM, David Miller wrote: > From: Or Gerlitz > Date: Tue, 16 Feb 2016 21:30:18 +0200 >> I thought we've got into agreement in netdev that the offloading >> directive would be a tri-state creature (sw, hw and fail the op if >> can't, hw and fallback to sw). Can you plea

Re: [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe

2016-02-16 Thread David Miller
From: Or Gerlitz Date: Tue, 16 Feb 2016 21:30:18 +0200 > On Tue, Feb 16, 2016 at 8:00 AM, John Fastabend > wrote: > [...] > >> Specifically this uses a 'big hammer' feature bit >> to do the offload or not. If the bit is set you get offloaded rules >> if it is not then rules will not be offloade

Re: [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe

2016-02-16 Thread Or Gerlitz
On Tue, Feb 16, 2016 at 8:00 AM, John Fastabend wrote: [...] > Specifically this uses a 'big hammer' feature bit > to do the offload or not. If the bit is set you get offloaded rules > if it is not then rules will not be offloaded. If we can agree on > this patch series there are some more patche

[net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe

2016-02-15 Thread John Fastabend
This extends the setup_tc framework so it can support more than just the mqprio offload and push other classifiers and qdiscs into the hardware. The series here targets the u32 classifier and ixgbe driver. I worked out the u32 classifier because it is protocol oblivious and aligns with multiple har