From: Or Gerlitz <gerlitz...@gmail.com> Date: Tue, 16 Feb 2016 21:30:18 +0200
> On Tue, Feb 16, 2016 at 8:00 AM, John Fastabend > <john.fastab...@gmail.com> wrote: > [...] > >> Specifically this uses a 'big hammer' feature bit >> to do the offload or not. If the bit is set you get offloaded rules >> if it is not then rules will not be offloaded. If we can agree on >> this patch series there are some more patches on my queue we can >> talk about to make the offload decision per rule using flags similar >> to how we do l2 mac updates. Additionally the error strategy can >> be improved to be hard aborting, log and continue, etc. I think >> these are nice to have improvements but shouldn't block this series. > > John, > > I thought we've got into agreement in netdev that the offloading > directive would be a tri-state creature (sw, hw and fail the op if > can't, hw and fallback to sw). Can you please elaborate what do you > mean by "make the offload decision per rule using flags similar to how > we do l2 mac updates" I think John's changes are an intermediate step in a long term evoluation. I'm going to apply John's changes as-is, and people can submit relative changes on top if they want.