Re: [net-next PATCH 0/7] stmmac: dwmac-sti refactor+cleanup

2016-11-04 Thread Joachim Eastwood
Hi Giuseppe, On 4 November 2016 at 14:49, Giuseppe CAVALLARO wrote: > Hello Joachim. > > I have tested the patches on STiH390 with GMAC4 and the driver is ok. > > So you can add my Acked-by/Tested-by in the V2. Thanks! I'll send a V2 later today or tomorrow. > I just ask you, when rename the s

Re: [net-next PATCH 0/7] stmmac: dwmac-sti refactor+cleanup

2016-11-04 Thread Giuseppe CAVALLARO
Hello Joachim. I have tested the patches on STiH390 with GMAC4 and the driver is ok. So you can add my Acked-by/Tested-by in the V2. I just ask you, when rename the sti_dwmac_init in sti_dwmac_set_phy_mode to use another name: sti_dwmac_set_mode could be good, IMO. In fact, this function is no

Re: [net-next PATCH 0/7] stmmac: dwmac-sti refactor+cleanup

2016-11-01 Thread Giuseppe CAVALLARO
Hello Joachim thx for this series, I will review them and test the changes on my board asap ... I let you known. Peppe On 10/30/2016 9:05 PM, Joachim Eastwood wrote: This patch set aims to remove the init/exit callbacks from the dwmac-sti driver and instead use standard PM callbacks. Doing thi

Re: [net-next PATCH 0/7] stmmac: dwmac-sti refactor+cleanup

2016-11-01 Thread Joachim Eastwood
Hi, On 1 November 2016 at 16:56, David Miller wrote: > From: David Miller > Date: Mon, 31 Oct 2016 15:47:26 -0400 (EDT) > >> From: Joachim Eastwood >> Date: Sun, 30 Oct 2016 21:05:00 +0100 >> >>> This patch set aims to remove the init/exit callbacks from the >>> dwmac-sti driver and instead use

Re: [net-next PATCH 0/7] stmmac: dwmac-sti refactor+cleanup

2016-11-01 Thread David Miller
From: David Miller Date: Mon, 31 Oct 2016 15:47:26 -0400 (EDT) > From: Joachim Eastwood > Date: Sun, 30 Oct 2016 21:05:00 +0100 > >> This patch set aims to remove the init/exit callbacks from the >> dwmac-sti driver and instead use standard PM callbacks. Doing this >> will also allow us to cle

Re: [net-next PATCH 0/7] stmmac: dwmac-sti refactor+cleanup

2016-10-31 Thread David Miller
From: Joachim Eastwood Date: Sun, 30 Oct 2016 21:05:00 +0100 > This patch set aims to remove the init/exit callbacks from the > dwmac-sti driver and instead use standard PM callbacks. Doing this > will also allow us to cleanup the driver. > > Eventually the init/exit callbacks will be deprecate

[net-next PATCH 0/7] stmmac: dwmac-sti refactor+cleanup

2016-10-30 Thread Joachim Eastwood
This patch set aims to remove the init/exit callbacks from the dwmac-sti driver and instead use standard PM callbacks. Doing this will also allow us to cleanup the driver. Eventually the init/exit callbacks will be deprecated and removed from all drivers dwmac-* except for dwmac-generic. Drivers