Hello Joachim. I have tested the patches on STiH390 with GMAC4 and the driver is ok.
So you can add my Acked-by/Tested-by in the V2. I just ask you, when rename the sti_dwmac_init in sti_dwmac_set_phy_mode to use another name: sti_dwmac_set_mode could be good, IMO. In fact, this function is not strictly related to the PHY and the system config registers could touch different MAC/MII settings. Regards Peppe On 10/30/2016 9:05 PM, Joachim Eastwood wrote:
This patch set aims to remove the init/exit callbacks from the dwmac-sti driver and instead use standard PM callbacks. Doing this will also allow us to cleanup the driver. Eventually the init/exit callbacks will be deprecated and removed from all drivers dwmac-* except for dwmac-generic. Drivers will be refactored to use standard PM and remove callbacks. Note that this patch set has only been test compiled and no functional change is intended. Joachim Eastwood (7): stmmac: dwmac-sti: remove useless of_node check stmmac: dwmac-sti: remove clk NULL checks stmmac: dwmac-sti: add PM ops and resume function stmmac: dwmac-sti: move st,gmac_en parsing to sti_dwmac_parse_data stmmac: dwmac-sti: move clk_prepare_enable out of init and add error handling stmmac: dwmac-sti: clean up and rename sti_dwmac_init stmmac: dwmac-sti: remove unused priv dev member drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 86 ++++++++++++++++--------- 1 file changed, 57 insertions(+), 29 deletions(-)
