RE: [net-next 15/17] fm10k: fix possible null pointer deref after kcalloc

2016-04-21 Thread Keller, Jacob E
> On Thu, 2016-04-21 at 15:47 -0400, David Miller wrote: > > From: "Keller, Jacob E" > > Date: Thu, 21 Apr 2016 19:44:24 + > > > > > Dave, please don't pull this patch. Krishneil found an issue with > > > this patch, and I sent a corrected fix to squash in but it didn't > > > make it into this

Re: [net-next 15/17] fm10k: fix possible null pointer deref after kcalloc

2016-04-21 Thread Jeff Kirsher
On Thu, 2016-04-21 at 15:47 -0400, David Miller wrote: > From: "Keller, Jacob E" > Date: Thu, 21 Apr 2016 19:44:24 + > > > Dave, please don't pull this patch. Krishneil found an issue with > > this patch, and I sent a corrected fix to squash in but it didn't > > make it into this one. I'd lik

Re: [net-next 15/17] fm10k: fix possible null pointer deref after kcalloc

2016-04-21 Thread David Miller
From: "Keller, Jacob E" Date: Thu, 21 Apr 2016 19:44:24 + > Dave, please don't pull this patch. Krishneil found an issue with > this patch, and I sent a corrected fix to squash in but it didn't > make it into this one. I'd like to get the fix squashed in a resend > before this is pulled into

RE: [net-next 15/17] fm10k: fix possible null pointer deref after kcalloc

2016-04-21 Thread Keller, Jacob E
> -Original Message- > From: Kirsher, Jeffrey T > Sent: Wednesday, April 20, 2016 11:09 PM > To: da...@davemloft.net > Cc: Keller, Jacob E ; netdev@vger.kernel.org; > nhor...@redhat.com; sassm...@redhat.com; jogre...@redhat.com; > Kirsher, Jeffrey T > Subject: [ne

[net-next 15/17] fm10k: fix possible null pointer deref after kcalloc

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller When writing a new default redirection table, we needed to populate a new RSS table using ethtool_rxfh_indir_default. We populated this table into a region of memory allocated using kcalloc, but never checked this for NULL. Fix this by moving the default table generation into f