> -----Original Message----- > From: Kirsher, Jeffrey T > Sent: Wednesday, April 20, 2016 11:09 PM > To: [email protected] > Cc: Keller, Jacob E <[email protected]>; [email protected]; > [email protected]; [email protected]; [email protected]; > Kirsher, Jeffrey T <[email protected]> > Subject: [net-next 15/17] fm10k: fix possible null pointer deref after kcalloc > > From: Jacob Keller <[email protected]> > > When writing a new default redirection table, we needed to populate > a new RSS table using ethtool_rxfh_indir_default. We populated this > table into a region of memory allocated using kcalloc, but never checked > this for NULL. Fix this by moving the default table generation into > fm10k_write_reta. If this function is passed a table, use it. Otherwise, > generate the default table using ethtool_rxfh_indir_default, 4 at at > time. > > Fixes: 0ea7fae44094 ("fm10k: use ethtool_rxfh_indir_default for default > redirection table") > Signed-off-by: Jacob Keller <[email protected]> > Signed-off-by: Jeff Kirsher <[email protected]> > ---
Hi Dave, and Jeff, Dave, please don't pull this patch. Krishneil found an issue with this patch, and I sent a corrected fix to squash in but it didn't make it into this one. I'd like to get the fix squashed in a resend before this is pulled into net-next. Thanks, Jake
