Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-08-01 Thread Moshe Shemesh
On Tue, Jul 31, 2018 at 2:06 PM, Bjorn Helgaas wrote: > On Mon, Jul 30, 2018 at 08:19:50PM -0700, Alexander Duyck wrote: > > On Mon, Jul 30, 2018 at 7:33 PM, Bjorn Helgaas > wrote: > > > On Mon, Jul 30, 2018 at 08:02:48AM -0700, Alexander Duyck wrote: > > >> On Mon, Jul 30, 2018 at 7:07 AM, Bjor

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-31 Thread Bjorn Helgaas
On Mon, Jul 30, 2018 at 08:19:50PM -0700, Alexander Duyck wrote: > On Mon, Jul 30, 2018 at 7:33 PM, Bjorn Helgaas wrote: > > On Mon, Jul 30, 2018 at 08:02:48AM -0700, Alexander Duyck wrote: > >> On Mon, Jul 30, 2018 at 7:07 AM, Bjorn Helgaas wrote: > >> > On Sun, Jul 29, 2018 at 03:00:28PM -0700,

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-30 Thread Alexander Duyck
On Mon, Jul 30, 2018 at 7:33 PM, Bjorn Helgaas wrote: > On Mon, Jul 30, 2018 at 08:02:48AM -0700, Alexander Duyck wrote: >> On Mon, Jul 30, 2018 at 7:07 AM, Bjorn Helgaas wrote: >> > On Sun, Jul 29, 2018 at 03:00:28PM -0700, Alexander Duyck wrote: >> >> On Sun, Jul 29, 2018 at 2:23 AM, Moshe Shem

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-30 Thread Bjorn Helgaas
On Mon, Jul 30, 2018 at 08:02:48AM -0700, Alexander Duyck wrote: > On Mon, Jul 30, 2018 at 7:07 AM, Bjorn Helgaas wrote: > > On Sun, Jul 29, 2018 at 03:00:28PM -0700, Alexander Duyck wrote: > >> On Sun, Jul 29, 2018 at 2:23 AM, Moshe Shemesh > >> wrote: > >> > On Sat, Jul 28, 2018 at 7:06 PM, Bj

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-30 Thread Jakub Kicinski
On Mon, 30 Jul 2018 08:02:48 -0700, Alexander Duyck wrote: > On Mon, Jul 30, 2018 at 7:07 AM, Bjorn Helgaas wrote: > > On Sun, Jul 29, 2018 at 03:00:28PM -0700, Alexander Duyck wrote: > >> On Sun, Jul 29, 2018 at 2:23 AM, Moshe Shemesh > >> wrote: > >> > On Sat, Jul 28, 2018 at 7:06 PM, Bjor

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-30 Thread Alexander Duyck
On Mon, Jul 30, 2018 at 7:07 AM, Bjorn Helgaas wrote: > On Sun, Jul 29, 2018 at 03:00:28PM -0700, Alexander Duyck wrote: >> On Sun, Jul 29, 2018 at 2:23 AM, Moshe Shemesh wrote: >> > On Sat, Jul 28, 2018 at 7:06 PM, Bjorn Helgaas wrote: >> >> On Thu, Jul 26, 2018 at 07:00:20AM -0700, Alexander D

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-30 Thread Bjorn Helgaas
On Sun, Jul 29, 2018 at 03:00:28PM -0700, Alexander Duyck wrote: > On Sun, Jul 29, 2018 at 2:23 AM, Moshe Shemesh wrote: > > On Sat, Jul 28, 2018 at 7:06 PM, Bjorn Helgaas wrote: > >> On Thu, Jul 26, 2018 at 07:00:20AM -0700, Alexander Duyck wrote: > >> > On Thu, Jul 26, 2018 at 12:14 AM, Jiri Pi

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-29 Thread Alexander Duyck
On Sun, Jul 29, 2018 at 2:23 AM, Moshe Shemesh wrote: > > > On Sat, Jul 28, 2018 at 7:06 PM, Bjorn Helgaas wrote: >> >> On Thu, Jul 26, 2018 at 07:00:20AM -0700, Alexander Duyck wrote: >> > On Thu, Jul 26, 2018 at 12:14 AM, Jiri Pirko wrote: >> > > Thu, Jul 26, 2018 at 02:43:59AM CEST, jakub.kic

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-29 Thread Moshe Shemesh
On Sat, Jul 28, 2018 at 7:06 PM, Bjorn Helgaas wrote: > On Thu, Jul 26, 2018 at 07:00:20AM -0700, Alexander Duyck wrote: > > On Thu, Jul 26, 2018 at 12:14 AM, Jiri Pirko wrote: > > > Thu, Jul 26, 2018 at 02:43:59AM CEST, jakub.kicin...@netronome.com > wrote: > > >>On Wed, 25 Jul 2018 08:23:26 -0

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-28 Thread Bjorn Helgaas
On Thu, Jul 26, 2018 at 07:00:20AM -0700, Alexander Duyck wrote: > On Thu, Jul 26, 2018 at 12:14 AM, Jiri Pirko wrote: > > Thu, Jul 26, 2018 at 02:43:59AM CEST, jakub.kicin...@netronome.com wrote: > >>On Wed, 25 Jul 2018 08:23:26 -0700, Alexander Duyck wrote: > >>> On Wed, Jul 25, 2018 at 5:31 AM,

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-26 Thread Alexander Duyck
On Thu, Jul 26, 2018 at 12:14 AM, Jiri Pirko wrote: > Thu, Jul 26, 2018 at 02:43:59AM CEST, jakub.kicin...@netronome.com wrote: >>On Wed, 25 Jul 2018 08:23:26 -0700, Alexander Duyck wrote: >>> On Wed, Jul 25, 2018 at 5:31 AM, Eran Ben Elisha wrote: >>> > On 7/24/2018 10:51 PM, Jakub Kicinski wrote

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-26 Thread Jiri Pirko
Thu, Jul 26, 2018 at 02:43:59AM CEST, jakub.kicin...@netronome.com wrote: >On Wed, 25 Jul 2018 08:23:26 -0700, Alexander Duyck wrote: >> On Wed, Jul 25, 2018 at 5:31 AM, Eran Ben Elisha wrote: >> > On 7/24/2018 10:51 PM, Jakub Kicinski wrote: >> The devlink params haven't been upstream even

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-25 Thread Jakub Kicinski
On Wed, 25 Jul 2018 08:23:26 -0700, Alexander Duyck wrote: > On Wed, Jul 25, 2018 at 5:31 AM, Eran Ben Elisha wrote: > > On 7/24/2018 10:51 PM, Jakub Kicinski wrote: > The devlink params haven't been upstream even for a full cycle and > already you guys are starting to use them to confi

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-25 Thread Alexander Duyck
On Wed, Jul 25, 2018 at 5:31 AM, Eran Ben Elisha wrote: > > > On 7/24/2018 10:51 PM, Jakub Kicinski wrote: The devlink params haven't been upstream even for a full cycle and already you guys are starting to use them to configure standard features like queuing. >>> >>> >>>

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-25 Thread Eran Ben Elisha
On 7/24/2018 10:51 PM, Jakub Kicinski wrote: The devlink params haven't been upstream even for a full cycle and already you guys are starting to use them to configure standard features like queuing. We developed the devlink params in order to support non-standard configuration only. And for

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-24 Thread Jakub Kicinski
On Tue, 24 Jul 2018 13:31:28 +0300, Eran Ben Elisha wrote: > On 7/19/2018 4:49 AM, Jakub Kicinski wrote: > > On Wed, 18 Jul 2018 18:01:01 -0700, Saeed Mahameed wrote: > >> +static const struct devlink_param mlx5_devlink_params[] = { > >> + DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_CONGESTION_AC

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-24 Thread Eran Ben Elisha
On 7/19/2018 4:49 AM, Jakub Kicinski wrote: On Wed, 18 Jul 2018 18:01:01 -0700, Saeed Mahameed wrote: +static const struct devlink_param mlx5_devlink_params[] = { + DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_CONGESTION_ACTION, +"congestion_action", +

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-19 Thread Eran Ben Elisha
> > This should not be num. It should be a string. Same for "mode". will fix for v2, thanks. > >

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-19 Thread Jiri Pirko
Thu, Jul 19, 2018 at 03:01:01AM CEST, sae...@mellanox.com wrote: >From: Eran Ben Elisha > >Add support for two driver parameters via devlink params interface: >- Congestion action > HW mechanism in the PCIe buffer which monitors the amount of > consumed PCIe buffer per host. This mech

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-18 Thread Jakub Kicinski
On Wed, 18 Jul 2018 18:01:01 -0700, Saeed Mahameed wrote: > +static const struct devlink_param mlx5_devlink_params[] = { > + DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_CONGESTION_ACTION, > + "congestion_action", > + DEVLINK_PARAM_TYPE_U8, > +

[net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-18 Thread Saeed Mahameed
From: Eran Ben Elisha Add support for two driver parameters via devlink params interface: - Congestion action HW mechanism in the PCIe buffer which monitors the amount of consumed PCIe buffer per host. This mechanism supports the following actions in case of threshold ove