Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

2018-08-15 Thread Stephen Hemminger
On Wed, 15 Aug 2018 18:51:15 +0200 Phil Sutter wrote: > On Wed, Aug 15, 2018 at 10:43:25AM -0600, David Ahern wrote: > > On 8/15/18 10:39 AM, Phil Sutter wrote: > > > On Wed, Aug 15, 2018 at 10:24:31AM -0600, David Ahern wrote: > > >> On 8/15/18 10:21 AM, Phil Sutter wrote: > > >>> Add an a

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

2018-08-15 Thread Phil Sutter
On Wed, Aug 15, 2018 at 10:57:13AM -0600, David Ahern wrote: > On 8/15/18 10:51 AM, Phil Sutter wrote: > > Should I respin the fixes or will you apply the series > > partially? > > Stephen has released 4.18 but not merged -next to master yet, so I > applied the first 3 to -next. OK, thanks! Chee

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

2018-08-15 Thread David Ahern
On 8/15/18 10:51 AM, Phil Sutter wrote: > Should I respin the fixes or will you apply the series > partially? Stephen has released 4.18 but not merged -next to master yet, so I applied the first 3 to -next.

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

2018-08-15 Thread Phil Sutter
On Wed, Aug 15, 2018 at 10:43:25AM -0600, David Ahern wrote: > On 8/15/18 10:39 AM, Phil Sutter wrote: > > On Wed, Aug 15, 2018 at 10:24:31AM -0600, David Ahern wrote: > >> On 8/15/18 10:21 AM, Phil Sutter wrote: > >>> Add an additional prerequisite to check_enable_color() to make sure > >>> stdout

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

2018-08-15 Thread David Ahern
On 8/15/18 10:39 AM, Phil Sutter wrote: > On Wed, Aug 15, 2018 at 10:24:31AM -0600, David Ahern wrote: >> On 8/15/18 10:21 AM, Phil Sutter wrote: >>> Add an additional prerequisite to check_enable_color() to make sure >>> stdout actually points to an open TTY device. Otherwise calls like >>> >>> |

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

2018-08-15 Thread Phil Sutter
On Wed, Aug 15, 2018 at 10:24:31AM -0600, David Ahern wrote: > On 8/15/18 10:21 AM, Phil Sutter wrote: > > Add an additional prerequisite to check_enable_color() to make sure > > stdout actually points to an open TTY device. Otherwise calls like > > > > | ip -color a s >/tmp/foo > > > > will prin

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

2018-08-15 Thread David Ahern
On 8/15/18 10:21 AM, Phil Sutter wrote: > Add an additional prerequisite to check_enable_color() to make sure > stdout actually points to an open TTY device. Otherwise calls like > > | ip -color a s >/tmp/foo > > will print color escape sequences into that file. Allow to override this > check by

[iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

2018-08-15 Thread Phil Sutter
Add an additional prerequisite to check_enable_color() to make sure stdout actually points to an open TTY device. Otherwise calls like | ip -color a s >/tmp/foo will print color escape sequences into that file. Allow to override this check by specifying '-color' flag more than once. Signed-off-b