Re: [benet] possible endianness bug in be_cmd_txq_create()

2018-01-28 Thread Sathya Perla
On Sun, Dec 10, 2017 at 10:11 PM, Al Viro wrote: > > In be_cmd_txq_create() we have > if (req->hdr.version > 0) > req->if_id = cpu_to_le16(adapter->if_handle); > req->num_pages = PAGES_4K_SPANNED(q_mem->va, q_mem->size); > req->ulp_num = BE_ULP1_NUM; >

Re: [benet] possible endianness bug in be_cmd_txq_create()

2017-12-10 Thread Al Viro
On Sun, Dec 10, 2017 at 06:43:08PM +, Al Viro wrote: > On Sun, Dec 10, 2017 at 04:41:20PM +, Al Viro wrote: > > > I don't have the hardware, so the above is completely untested (caught by > > sparse when trying to do endianness annotations in drivers/net), but it > > does look like it migh

Re: [benet] possible endianness bug in be_cmd_txq_create()

2017-12-10 Thread Al Viro
On Sun, Dec 10, 2017 at 04:41:20PM +, Al Viro wrote: > I don't have the hardware, so the above is completely untested (caught by > sparse when trying to do endianness annotations in drivers/net), but it > does look like it might be worth a look from benet maintainers. Another very fishy place

[benet] possible endianness bug in be_cmd_txq_create()

2017-12-10 Thread Al Viro
In be_cmd_txq_create() we have if (req->hdr.version > 0) req->if_id = cpu_to_le16(adapter->if_handle); req->num_pages = PAGES_4K_SPANNED(q_mem->va, q_mem->size); req->ulp_num = BE_ULP1_NUM; req->type = BE_ETH_TX_RING_TYPE_STANDARD; req->cq_id