Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-19 Thread Nikolay Aleksandrov
On 19/01/2021 02:42, Vladimir Oltean wrote: > On Tue, Jan 19, 2021 at 12:42:04AM +0200, Nikolay Aleksandrov wrote: >> No, it shouldn't be a problem to change that. We should be careful about the >> way it's changed though because reporting it for all ports might become a >> scale >> issue with 4k

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Vladimir Oltean
On Tue, Jan 19, 2021 at 12:42:04AM +0200, Nikolay Aleksandrov wrote: > No, it shouldn't be a problem to change that. We should be careful about the > way it's changed though because reporting it for all ports might become a > scale > issue with 4k vlans, and also today you can't add the same mac f

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Nikolay Aleksandrov
On 19/01/2021 00:06, Vladimir Oltean wrote: > On Mon, Jan 18, 2021 at 11:53:18PM +0200, Nikolay Aleksandrov wrote: >> On 18/01/2021 23:50, Vladimir Oltean wrote: >>> On Mon, Jan 18, 2021 at 11:39:27PM +0200, Nikolay Aleksandrov wrote: Apologies for the multiple emails, but wanted to leave an e

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Vladimir Oltean
On Tue, Jan 19, 2021 at 12:06:16AM +0200, Vladimir Oltean wrote: > And these: > > $ ip link add br0 type bridge > $ ip link set swp3 master br0 > $ ip link set swp2 master br0 > $ ip link set swp1 master br0 > $ ip link set swp0 master br0 > $ bridge fdb | grep permanent > 00:04:9f:05:de:0a dev sw

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Vladimir Oltean
On Mon, Jan 18, 2021 at 11:53:18PM +0200, Nikolay Aleksandrov wrote: > On 18/01/2021 23:50, Vladimir Oltean wrote: > > On Mon, Jan 18, 2021 at 11:39:27PM +0200, Nikolay Aleksandrov wrote: > >> Apologies for the multiple emails, but wanted to leave an example: > >> > >> 00:11:22:33:44:55 dev ens16 m

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Nikolay Aleksandrov
On 18/01/2021 23:50, Vladimir Oltean wrote: > On Mon, Jan 18, 2021 at 11:39:27PM +0200, Nikolay Aleksandrov wrote: >> Apologies for the multiple emails, but wanted to leave an example: >> >> 00:11:22:33:44:55 dev ens16 master bridge permanent >> >> This must always exist and user-space must be able

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Vladimir Oltean
On Mon, Jan 18, 2021 at 11:39:27PM +0200, Nikolay Aleksandrov wrote: > Apologies for the multiple emails, but wanted to leave an example: > > 00:11:22:33:44:55 dev ens16 master bridge permanent > > This must always exist and user-space must be able to create it, which > might be against what you

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Nikolay Aleksandrov
On 18/01/2021 23:22, Nikolay Aleksandrov wrote: > On 18/01/2021 23:17, Nikolay Aleksandrov wrote: >> On 18/01/2021 22:19, Tobias Waldekranz wrote: >>> On Mon, Jan 18, 2021 at 21:27, Vladimir Oltean wrote: On Mon, Jan 18, 2021 at 07:58:59PM +0100, Tobias Waldekranz wrote: > Ah I see, no I

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Nikolay Aleksandrov
On 18/01/2021 23:17, Nikolay Aleksandrov wrote: > On 18/01/2021 22:19, Tobias Waldekranz wrote: >> On Mon, Jan 18, 2021 at 21:27, Vladimir Oltean wrote: >>> On Mon, Jan 18, 2021 at 07:58:59PM +0100, Tobias Waldekranz wrote: Ah I see, no I was not aware of that. I just saw that the entry towar

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Nikolay Aleksandrov
On 18/01/2021 22:19, Tobias Waldekranz wrote: > On Mon, Jan 18, 2021 at 21:27, Vladimir Oltean wrote: >> On Mon, Jan 18, 2021 at 07:58:59PM +0100, Tobias Waldekranz wrote: >>> Ah I see, no I was not aware of that. I just saw that the entry towards >>> the CPU was added to the ATU, which it would i

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Vladimir Oltean
On Mon, Jan 18, 2021 at 09:19:11PM +0100, Tobias Waldekranz wrote: > > My only hope is that we could just offload the entries pointing towards > > br0, and ignore the local ones. > > That was my initial approach. Unfortunately that breaks down when the > bridge inherits its address from a port, i.

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Tobias Waldekranz
On Mon, Jan 18, 2021 at 21:27, Vladimir Oltean wrote: > On Mon, Jan 18, 2021 at 07:58:59PM +0100, Tobias Waldekranz wrote: >> Ah I see, no I was not aware of that. I just saw that the entry towards >> the CPU was added to the ATU, which it would in both cases. I.e. from >> the switch's POV, in thi

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Ido Schimmel
On Sun, Jan 17, 2021 at 09:30:09PM +0200, Vladimir Oltean wrote: > Hi Tobias, > > On Sat, Jan 16, 2021 at 02:25:10AM +0100, Tobias Waldekranz wrote: > > Some switchdev drivers, notably DSA, ignore all dynamically learned > > address notifications (!added_by_user) as these are autonomously added >

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Vladimir Oltean
On Mon, Jan 18, 2021 at 07:58:59PM +0100, Tobias Waldekranz wrote: > Ah I see, no I was not aware of that. I just saw that the entry towards > the CPU was added to the ATU, which it would in both cases. I.e. from > the switch's POV, in this setup: > >br0 >/ \ (A) > swp0 dummy0 >(B)

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Tobias Waldekranz
On Sun, Jan 17, 2021 at 21:30, Vladimir Oltean wrote: > Hi Tobias, > > On Sat, Jan 16, 2021 at 02:25:10AM +0100, Tobias Waldekranz wrote: >> Some switchdev drivers, notably DSA, ignore all dynamically learned >> address notifications (!added_by_user) as these are autonomously added >> by the switc

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-17 Thread Vladimir Oltean
Hi Tobias, On Sat, Jan 16, 2021 at 02:25:10AM +0100, Tobias Waldekranz wrote: > Some switchdev drivers, notably DSA, ignore all dynamically learned > address notifications (!added_by_user) as these are autonomously added > by the switch. Previously, such a notification was indistinguishable > from

[RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-15 Thread Tobias Waldekranz
Some switchdev drivers, notably DSA, ignore all dynamically learned address notifications (!added_by_user) as these are autonomously added by the switch. Previously, such a notification was indistinguishable from a local address notification. Include a local bit in the notification so that the two