Re: [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol

2016-05-06 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > On Thu, May 05, 2016 at 06:41:03PM -0400, Vivien Didelot wrote: >> 6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA. >> Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all >> other mv88e6xxx drivers. > > You might as well r

Re: [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol

2016-05-05 Thread Andrew Lunn
On Thu, May 05, 2016 at 06:41:03PM -0400, Vivien Didelot wrote: > 6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA. > Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all > other mv88e6xxx drivers. Hi Vivien You might as well remove net/dsa/tag_dsa.c as well

[RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol

2016-05-05 Thread Vivien Didelot
6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA. Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all other mv88e6xxx drivers. Signed-off-by: Vivien Didelot --- drivers/net/dsa/Kconfig | 2 +- drivers/net/dsa/mv88e6131.c | 2 +- 2 files changed, 2 inse