Re: [RFC PATCH net-next 03/19] ipv6: Clear nexthop flags upon netdev up

2018-01-03 Thread David Ahern
On 1/3/18 1:53 PM, Ido Schimmel wrote: > On Wed, Jan 03, 2018 at 11:47:16AM -0700, David Ahern wrote: >> On 1/3/18 10:40 AM, Ido Schimmel wrote: >>> David, can we please get back to the issue at hand? What's the problem >>> with the location of the call to rt6_sync_up()? >> >> My original comment w

Re: [RFC PATCH net-next 03/19] ipv6: Clear nexthop flags upon netdev up

2018-01-03 Thread Ido Schimmel
On Wed, Jan 03, 2018 at 11:47:16AM -0700, David Ahern wrote: > On 1/3/18 10:40 AM, Ido Schimmel wrote: > > David, can we please get back to the issue at hand? What's the problem > > with the location of the call to rt6_sync_up()? > > My original comment was asking why do it on NETDEV_CHANGE when i

Re: [RFC PATCH net-next 03/19] ipv6: Clear nexthop flags upon netdev up

2018-01-03 Thread David Ahern
On 1/3/18 10:40 AM, Ido Schimmel wrote: > David, can we please get back to the issue at hand? What's the problem > with the location of the call to rt6_sync_up()? My original comment was asking why do it on NETDEV_CHANGE when it should only be needed on NETDEV_UP.

Re: [RFC PATCH net-next 03/19] ipv6: Clear nexthop flags upon netdev up

2018-01-03 Thread Ido Schimmel
On Wed, Jan 03, 2018 at 09:56:02AM -0700, David Ahern wrote: > On 1/3/18 9:43 AM, Ido Schimmel wrote: > > On Wed, Jan 03, 2018 at 08:32:51AM -0700, David Ahern wrote: > >> On 1/3/18 12:44 AM, Ido Schimmel wrote: > > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > > index ed06b1190f

Re: [RFC PATCH net-next 03/19] ipv6: Clear nexthop flags upon netdev up

2018-01-03 Thread David Ahern
On 1/3/18 9:43 AM, Ido Schimmel wrote: > On Wed, Jan 03, 2018 at 08:32:51AM -0700, David Ahern wrote: >> On 1/3/18 12:44 AM, Ido Schimmel wrote: > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index ed06b1190f05..b6405568ed7b 100644 > --- a/net/ipv6/addrconf.c > +++ b/net

Re: [RFC PATCH net-next 03/19] ipv6: Clear nexthop flags upon netdev up

2018-01-03 Thread Ido Schimmel
On Wed, Jan 03, 2018 at 08:32:51AM -0700, David Ahern wrote: > On 1/3/18 12:44 AM, Ido Schimmel wrote: > >>> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > >>> index ed06b1190f05..b6405568ed7b 100644 > >>> --- a/net/ipv6/addrconf.c > >>> +++ b/net/ipv6/addrconf.c > >>> @@ -3484,6 +3484,9

Re: [RFC PATCH net-next 03/19] ipv6: Clear nexthop flags upon netdev up

2018-01-03 Thread David Ahern
On 1/3/18 12:44 AM, Ido Schimmel wrote: >>> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c >>> index ed06b1190f05..b6405568ed7b 100644 >>> --- a/net/ipv6/addrconf.c >>> +++ b/net/ipv6/addrconf.c >>> @@ -3484,6 +3484,9 @@ static int addrconf_notify(struct notifier_block >>> *this, unsigned

Re: [RFC PATCH net-next 03/19] ipv6: Clear nexthop flags upon netdev up

2018-01-02 Thread Ido Schimmel
Hi David, On Tue, Jan 02, 2018 at 09:20:47AM -0700, David Ahern wrote: > On 12/31/17 9:14 AM, Ido Schimmel wrote: > > Previous patch marked nexthops with the 'dead' and 'linkdown' flags. > > Clear these flags when the netdev comes back up. > > > > Signed-off-by: Ido Schimmel > > --- > > include

Re: [RFC PATCH net-next 03/19] ipv6: Clear nexthop flags upon netdev up

2018-01-02 Thread David Ahern
On 12/31/17 9:14 AM, Ido Schimmel wrote: > Previous patch marked nexthops with the 'dead' and 'linkdown' flags. > Clear these flags when the netdev comes back up. > > Signed-off-by: Ido Schimmel > --- > include/net/ip6_route.h | 1 + > net/ipv6/addrconf.c | 3 +++ > net/ipv6/route.c

[RFC PATCH net-next 03/19] ipv6: Clear nexthop flags upon netdev up

2017-12-31 Thread Ido Schimmel
Previous patch marked nexthops with the 'dead' and 'linkdown' flags. Clear these flags when the netdev comes back up. Signed-off-by: Ido Schimmel --- include/net/ip6_route.h | 1 + net/ipv6/addrconf.c | 3 +++ net/ipv6/route.c| 29 + 3 files changed, 33