On 1/3/18 1:53 PM, Ido Schimmel wrote: > On Wed, Jan 03, 2018 at 11:47:16AM -0700, David Ahern wrote: >> On 1/3/18 10:40 AM, Ido Schimmel wrote: >>> David, can we please get back to the issue at hand? What's the problem >>> with the location of the call to rt6_sync_up()? >> >> My original comment was asking why do it on NETDEV_CHANGE when it should >> only be needed on NETDEV_UP. > > I can condition the call to rt6_sync_up() on the event being NETDEV_UP, > but the location needs to stay the same. Before that the interface still > doesn't have an IP address.
it's fine as is. The NETDEV_CHANGE section has a break after calling rt6_sync_up(RTNH_F_LINKDOWN) which is added later. To your point, addrconf_dev_config will add a linklocal address.
