Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-08 Thread [EMAIL PROTECTED]
(using webmail) >- Oorspronkelijk bericht - >Van: Harald Welte [mailto:[EMAIL PROTECTED] >Ok, so this is actually the opposite problem of the ipt_physdev.c >problem. Here we have the physical device, but not the bridge group. > >This means we have to handle two separate cases: > >1) when

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-08 Thread Harald Welte
[removing kaber and davem from cc list] On Mon, Aug 08, 2005 at 06:57:40AM +, Bart De Schuymer wrote: > > So I think it should reflect exactly what you currently do in ebt_ulog. > > The only diference is that you now get the ifindex and not the device > > name string. > > These two code fragm

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-07 Thread Bart De Schuymer
Op zo, 07-08-2005 te 23:33 +0200, schreef Harald Welte: > > indev->br_port->br->dev->ifindex points to the ifindex of the bridge br0 > > when indev is a bridge port (eth0). So you need this to fill in the > > input device (assuming we agree that the bridge is called the input > > device, and the b

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-07 Thread Harald Welte
On Sun, Aug 07, 2005 at 09:27:56PM +, Bart De Schuymer wrote: > > I really hate to have those CONFIG_BRIDGE_NETFILTER ifdef's all over the > > code - but for now we have them almost everywhere, so two more doesn't > > hurt. At some point we need to get rid of this ugliness and have something >

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-07 Thread Bart De Schuymer
Op vr, 05-08-2005 te 19:10 +0200, schreef Harald Welte: > What about the following (only compile-tested) patch ? > > [NETFILTER] add phys{in,out}dev support to nfnetlink_log and nfnetlink_queue > > Since bridges don't have a 'reasonable' input and output net_device > (e.g. 'br0'), we need to add

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-05 Thread Harald Welte
On Fri, Aug 05, 2005 at 06:37:09PM +0200, Harald Welte wrote: > Ok, I'll extend nfnetlink_log.c to add TLV's for those two fields in > case CONFIG_BRIDGE_NF is set. I'll send a patch later tonight. What about the following (only compile-tested) patch ? [NETFILTER] add phys{in,out}dev support to

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-05 Thread Harald Welte
On Fri, Aug 05, 2005 at 11:26:07AM +, Bart De Schuymer wrote: > I don't think your patch will satisfy the simple and rational demand of > people using userspace logging on a bridging firewall: they like to know > what bridge port the packet arrived at/will leave by. These are the > physindev a

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-05 Thread Bart De Schuymer
Op zo, 31-07-2005 te 09:05 +0200, schreef Harald Welte: > On Sat, Jul 30, 2005 at 09:04:23PM -0700, David S. Miller wrote: > > > > attached is a patch that converts ebt_ulog to use the generic logging > > > mechanism (and thus be able to use the nfnetlink_log backend). > > > > > > This patch bre

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-07-31 Thread Harald Welte
On Sat, Jul 30, 2005 at 09:04:23PM -0700, David S. Miller wrote: > > attached is a patch that converts ebt_ulog to use the generic logging > > mechanism (and thus be able to use the nfnetlink_log backend). > > > > This patch breaks userspace compatibility, since the netlink message > > format of

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-07-30 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Sat, 30 Jul 2005 13:03:53 +0200 > attached is a patch that converts ebt_ulog to use the generic logging > mechanism (and thus be able to use the nfnetlink_log backend). > > This patch breaks userspace compatibility, since the netlink message > format o

[RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-07-30 Thread Harald Welte
Hi Bart, Dave, Patrick, attached is a patch that converts ebt_ulog to use the generic logging mechanism (and thus be able to use the nfnetlink_log backend). This patch breaks userspace compatibility, since the netlink message format of nfnetlink_log is different than the ebt_ulog one. I cannot d