Op zo, 31-07-2005 te 09:05 +0200, schreef Harald Welte: > On Sat, Jul 30, 2005 at 09:04:23PM -0700, David S. Miller wrote: > > > > attached is a patch that converts ebt_ulog to use the generic logging > > > mechanism (and thus be able to use the nfnetlink_log backend). > > > > > > This patch breaks userspace compatibility, since the netlink message > > > format of nfnetlink_log is different than the ebt_ulog one. I cannot > > > decide whether that can be done, but at least in the past I had the > > > feeling that nobody is really using ebt_ulog [yet], and thus it might be > > > possible for those few users to directly use libnfnetlink_log > > > (https://svn.netfilter.org/netfilter/trunk/libnfnetlink_log), especially > > > considering that those uerspace apps already breaks since ebt_ulog now > > > uses a different netlink family. > > > > I like it, let me know when you'd like me to apply it. > > Well, it was marked as [RFC] since I'd actually like Bart to comment on > it first. Revoking someone elses' code from the tree is quite serious, > and nothing that I would somebody else see doing with my code either. > > Since this is net-2.6.14, I guess we have some time left to get this > sorted out.
Thanks Harald. I don't think your patch will satisfy the simple and rational demand of people using userspace logging on a bridging firewall: they like to know what bridge port the packet arrived at/will leave by. These are the physindev and physoutdev members of the struct ebt_ulog_packet_msg. Apart from that, I have no objection with introducing incompatibilities between the output from the old ebt_ulog and the new one using generic functions; as long as there is no information loss. cheers, Bart - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
