Re: [Patch net] inet: fix sleeping inside inet_wait_for_connect()

2016-11-03 Thread David Miller
From: Cong Wang Date: Tue, 1 Nov 2016 16:04:36 -0700 > Andrey reported this kernel warning: ... > Unlike commit 26cabd31259ba43f68026ce3f62b78094124333f > ("sched, net: Clean up sk_wait_event() vs. might_sleep()"), the > sleeping function is called before schedule_timeout(), this is indeed > a

Re: [Patch net] inet: fix sleeping inside inet_wait_for_connect()

2016-11-02 Thread Cong Wang
On Tue, Nov 1, 2016 at 6:54 PM, Eric Dumazet wrote: > On Tue, 2016-11-01 at 16:04 -0700, Cong Wang wrote: >> Andrey reported this kernel warning: > >> Unlike commit 26cabd31259ba43f68026ce3f62b78094124333f >> ("sched, net: Clean up sk_wait_event() vs. might_sleep()"), the >> sleeping function is c

Re: [Patch net] inet: fix sleeping inside inet_wait_for_connect()

2016-11-01 Thread Eric Dumazet
On Tue, 2016-11-01 at 16:04 -0700, Cong Wang wrote: > Andrey reported this kernel warning: > Unlike commit 26cabd31259ba43f68026ce3f62b78094124333f > ("sched, net: Clean up sk_wait_event() vs. might_sleep()"), the > sleeping function is called before schedule_timeout(), this is indeed > a bug. Fix

[Patch net] inet: fix sleeping inside inet_wait_for_connect()

2016-11-01 Thread Cong Wang
Andrey reported this kernel warning: WARNING: CPU: 0 PID: 4608 at kernel/sched/core.c:7724 __might_sleep+0x14c/0x1a0 kernel/sched/core.c:7719 do not call blocking ops when !TASK_RUNNING; state=1 set at [] prepare_to_wait+0xbc/0x210 kernel/sched/wait.c:178 Modules linked in: CPU: 0 PI