Re: [PATCHv2 1/1] forcedeth: use per cpu to collect xmit/recv statistics

2019-09-04 Thread David Miller
From: Zhu Yanjun Date: Thu, 5 Sep 2019 10:48:01 +0800 > > On 2019/9/5 6:22, David Miller wrote: >> From: Zhu Yanjun >> Date: Sun, 1 Sep 2019 03:26:13 -0400 >> >>> +static inline void nv_get_stats(int cpu, struct fe_priv *np, >>> + struct rtnl_link_stats64 *storage) >>

Re: [PATCHv2 1/1] forcedeth: use per cpu to collect xmit/recv statistics

2019-09-04 Thread Zhu Yanjun
On 2019/9/5 6:22, David Miller wrote: From: Zhu Yanjun Date: Sun, 1 Sep 2019 03:26:13 -0400 +static inline void nv_get_stats(int cpu, struct fe_priv *np, + struct rtnl_link_stats64 *storage) ... +static inline void rx_missing_handler(u32 flags, struct fe_pr

Re: [PATCHv2 1/1] forcedeth: use per cpu to collect xmit/recv statistics

2019-09-04 Thread David Miller
From: Zhu Yanjun Date: Sun, 1 Sep 2019 03:26:13 -0400 > +static inline void nv_get_stats(int cpu, struct fe_priv *np, > + struct rtnl_link_stats64 *storage) ... > +static inline void rx_missing_handler(u32 flags, struct fe_priv *np) > +{ Never use the inline keyword

[PATCHv2 1/1] forcedeth: use per cpu to collect xmit/recv statistics

2019-09-01 Thread Zhu Yanjun
When testing with a background iperf pushing 1Gbit/sec traffic and running both ifconfig and netstat to collect statistics, some deadlocks occurred. Ifconfig and netstat will call nv_get_stats64 to get software xmit/recv statistics. In the commit f5d827aece36 ("forcedeth: implement ndo_get_stats64