From: Zhu Yanjun <yanjun....@oracle.com> Date: Thu, 5 Sep 2019 10:48:01 +0800
> > On 2019/9/5 6:22, David Miller wrote: >> From: Zhu Yanjun <yanjun....@oracle.com> >> Date: Sun, 1 Sep 2019 03:26:13 -0400 >> >>> +static inline void nv_get_stats(int cpu, struct fe_priv *np, >>> + struct rtnl_link_stats64 *storage) >> ... >>> +static inline void rx_missing_handler(u32 flags, struct fe_priv *np) >>> +{ >> Never use the inline keyword in foo.c files, let the compiler decide. > > Thanks a lot for your advice. I will pay attention to the usage of > inline in the > > source code. > > If you agree, I will send V3 about this soon. Of course "I agree" with my own feedback. Please just make V3 with the inline keywords removed.