On 12/12/18 4:33 AM, Joakim Tjernlund wrote:
> This allows to control carrier from /sys/class/net/ethX/carrier for
> Fixed PHYs.
>
> Signed-off-by: Joakim Tjernlund
> ---
> v2 - Only allow carrier changes for Fixed PHYs
>
> Florian: I have reimpl. this as I think you meant by registering
>
On Wed, 2018-12-12 at 15:51 +0100, Andrew Lunn wrote:
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you recognize the sender and know the
> content is safe.
>
>
> > fast check, would you be happy with this in fixed PHY:
> > --
> fast check, would you be happy with this in fixed PHY:
> --- a/drivers/net/phy/fixed_phy.c
> +++ b/drivers/net/phy/fixed_phy.c
> @@ -25,6 +25,7 @@
> #include
> #include
> #include
> +#include
>
> #include "swphy.h"
>
> @@ -38,6 +39,7 @@ struct fixed_phy {
> struct phy_device *
> > From: Andrew Lunn
> > Sent: Wednesday, December 12, 2018 2:43 PM
> > To: jo...@infinera.com
> > Cc: netdev @ vger . kernel . org ; Claudiu Manoil
> > ; Florian Fainelli
> > Subject: Re: [PATCHv2] gianfar: Add gfar_change_carrier() for Fixed PHYs
> >
>
> > From: Andrew Lunn
> > Sent: Wednesday, December 12, 2018 2:43 PM
> > To: jo...@infinera.com
> > Cc: netdev @ vger . kernel . org ; Claudiu Manoil
> > ; Florian Fainelli
> > Subject: Re: [PATCHv2] gianfar: Add gfar_change_carrier() for Fixed PHYs
> >
>
>-Original Message-
>From: Andrew Lunn
>Sent: Wednesday, December 12, 2018 2:43 PM
>To: jo...@infinera.com
>Cc: netdev @ vger . kernel . org ; Claudiu Manoil
>; Florian Fainelli
>Subject: Re: [PATCHv2] gianfar: Add gfar_change_carrier() for Fixed PHYs
>
>On
On Wed, Dec 12, 2018 at 01:33:08PM +0100, Joakim Tjernlund wrote:
> This allows to control carrier from /sys/class/net/ethX/carrier for
> Fixed PHYs.
>
> Signed-off-by: Joakim Tjernlund
> ---
> v2 - Only allow carrier changes for Fixed PHYs
>
> Florian: I have reimpl. this as I think you meant
This allows to control carrier from /sys/class/net/ethX/carrier for
Fixed PHYs.
Signed-off-by: Joakim Tjernlund
---
v2 - Only allow carrier changes for Fixed PHYs
Florian: I have reimpl. this as I think you meant by registering
a Fixed PHY callback.
Andrew: Are happy with this as we
