On Wed, Dec 12, 2018 at 01:33:08PM +0100, Joakim Tjernlund wrote: > This allows to control carrier from /sys/class/net/ethX/carrier for > Fixed PHYs. > > Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com> > --- > v2 - Only allow carrier changes for Fixed PHYs > > Florian: I have reimpl. this as I think you meant by registering > a Fixed PHY callback. > Andrew: Are happy with this as well?
Hi Joakim The basic idea is O.K. > > If this is OK I will sent the other 2 drivers. Rather than replicating the code three times, how about putting all the code in the fixed phy driver, exporting a fixed_phy_change_carrier function which can be assigned to the .ndo. Andrew